You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
[x] bug report
[x] feature request (mainly is a bug report, but bug has been found trying to get a feature)
Plunkr Case (Bug Reports)
Please fork the plunkr below and create a case demonstrating your bug report. Issues without a plunkr have much less possibility to be reviewed.
Note: My original scope was to use ev.originalEvent.preventDefault() to prevent slide action to work in some situations (the originalEvent is cancelable), but the onChange event is called after the change take place.
I'm wondering if this can be fixed/changed too:
calculate the next value
call onChange
check for originalEvent.defaultPrevented
if is false: calling setState to change stored values
Please tell us about your environment:
React version:
16.3.1
PrimeReact version:
1.5.1
Browser: [all | Chrome XX | Firefox XX | IE XX | Safari XX | Mobile Chrome XX | Android X.X Chrome
Note: My original scope was to use ev.originalEvent.preventDefault() to prevent slide action to work in some situations (the originalEvent is cancelable), but the onChange event is called after the change take place.
I'm submitting a ... (check one with "x")
Plunkr Case (Bug Reports)
Please fork the plunkr below and create a case demonstrating your bug report. Issues without a plunkr have much less possibility to be reviewed.
https://plnkr.co/edit/2E9ZKVxjEAtTsjkDP11O?p=preview
Current behavior
If I provide a
step
parameter (even if "1") I get noev.originalEvent
.Expected behavior
I think that
originalEvent
should be always thereMinimal reproduction of the problem with instructions
I think that issue is in the
setValueFromHandle
function. event if not passed over when have step:See:
primereact/src/components/slider/Slider.js
Line 85 in 3244b1e
When I don't have step:
primereact/src/components/slider/Slider.js
Line 89 in 3244b1e
Note: My original scope was to use ev.originalEvent.preventDefault() to prevent slide action to work in some situations (the originalEvent is
cancelable
), but the onChange event is called after the change take place.I'm wondering if this can be fixed/changed too:
false
: calling setState to change stored valuesPlease tell us about your environment:
React version:
16.3.1
PrimeReact version:
1.5.1
Browser: [all | Chrome XX | Firefox XX | IE XX | Safari XX | Mobile Chrome XX | Android X.X Chrome
Language: [all | TypeScript X.X | ES6/7 | ES5]
ES 6
The text was updated successfully, but these errors were encountered: