Button: Tooltip remains displayed after button is disabled

[melloware]

Describe the bug

Button with showOnDisabled="false" leaves tooltip permanently displayed when disabling the button.

<Button
            type="button"
            label="Save"
            icon="pi pi-check"
            disabled={disabled}
            tooltip={saveBtnTooltipText}
            tooltipOptions={{ showOnDisabled: false }}
            onClick={() => setDisabled(true)}
          />

Reproducer

https://codesandbox.io/s/goofy-merkle-u5hbhs?file=/src/demo/TooltipDemo.js

PrimeReact version

8.7.2

React version

17.x

Language

ALL

Build / Runtime

Create React App (CRA)

Browser(s)

Chrome

Steps to reproduce the behavior

1. hover button to display tooltip
2. press button to disable it and the tooltip remains displayed permanently.

Expected behavior

Tooltip should disappear when disabling the button.

[mertsincan]

I need to check for changes in Tooltip.js. It breaks some situations in layouts.

[melloware]

Thanks! By switching from Mount Effect + Update Effect to just a single React.useEffect reduces the amount of registered listeners. Show and Hide events were being registered twice on all components and this is due to the fact the functions being added are anonymous.

See MDN: https://developer.mozilla.org/en-US/docs/Web/API/EventTarget/addEventListener

Note: If a particular anonymous function is in the list of event listeners registered for a certain target, and then later in the code, an identical anonymous function is given in an addEventListener call, the second function will also be added to the list of event listeners for that target.

Indeed, anonymous functions are not identical even if defined using the same unchanging source-code called repeatedly, even if in a loop.

Repeatedly defining the same unnamed function in such cases can be problematic. (See Memory issues, below.)

If you go to the current showcase and Inspect the button with a tooltip registered you will see this...

[melloware]

I reverted the tooltip change and opened a new ticket: #3701