Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SpeedDial: allow aria-label attribute #3254

Closed
kyybo opened this issue Sep 7, 2022 · 1 comment · Fixed by #3255
Closed

SpeedDial: allow aria-label attribute #3254

kyybo opened this issue Sep 7, 2022 · 1 comment · Fixed by #3255
Assignees
@melloware
Labels
Component: Accessibility Issue or pull request is related to WCAG or ARIA Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Milestone
8.6.0

Comments

@kyybo
Copy link
Contributor

kyybo commented Sep 7, 2022

Describe the feature you would like to see added

I would really like to allow the aria-label attribute on the SpeedDial component so that the generated button has this property.

I think it would also be interesting to be able to allow the aria-label attribute in the items of the MenuItem component.

Is your feature request related to a problem?

No response

Describe the solution you'd like

No response

Describe alternatives you have considered

Currently I can manage to add the aria-label attribute on the button generated by the SpeedDial component by passing the 'buttonTemplate' property. But by doing that, I have to redefine all the behaviors (show/hide menu) of the SpeedDial component.

Additional context

No response
@kyybo kyybo added Status: Discussion Issue or pull request needs to be discussed by Core Team Type: New Feature Issue contains a new feature or new component request labels Sep 7, 2022
@melloware melloware changed the title Component: SpeedDial, allow aria-label attribute SpeedDial: allow aria-label attribute Sep 7, 2022
melloware added a commit to melloware/primereact that referenced this issue Sep 7, 2022
@melloware
Fix primefaces#3254: SpeedDial pass aria-label through to button
e16245d
@melloware melloware mentioned this issue Sep 7, 2022
Merged
@melloware melloware removed the Status: Discussion Issue or pull request needs to be discussed by Core Team label Sep 7, 2022
@melloware melloware self-assigned this Sep 7, 2022
@melloware melloware added this to the 8.6.0 milestone Sep 7, 2022
@melloware
Copy link
Member

Agreed i have made it so <SpeedDial model={items} direction="up" aria-label="My Aria Label" /> will put the aria-label on the Button and not the DIV of the Speed Dial.

@melloware melloware added Component: Accessibility Issue or pull request is related to WCAG or ARIA and removed Type: New Feature Issue contains a new feature or new component request labels Sep 7, 2022
melloware added a commit that referenced this issue Sep 7, 2022
@melloware
Fix #3254: SpeedDial pass aria-label through to button (#3255)
9b52d85
@mertsincan mertsincan added the Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add label Sep 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@melloware melloware

Labels
Component: Accessibility Issue or pull request is related to WCAG or ARIA Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Projects
None yet
Milestone
8.6.0
Development

Successfully merging a pull request may close this issue.

Fix #3254: SpeedDial pass aria-label through to button melloware/primereact
3 participants
@melloware @mertsincan @kyybo