Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FileUpload: Fix TypeScript FileUploadSelectParams #3235

Closed
melloware opened this issue Sep 3, 2022 · 0 comments · Fixed by #3236
Closed

FileUpload: Fix TypeScript FileUploadSelectParams #3235

melloware opened this issue Sep 3, 2022 · 0 comments · Fixed by #3236
Assignees
@melloware
Labels
Core Team Issue or pull request has been *opened* by a member of Core Team Type: Bug Issue contains a defect related to a specific component. Typescript Issue or pull request is *only* related to TypeScript definition
Milestone
8.5.0

Comments

@melloware
Copy link
Member

Describe the bug

The FileUploadSelectParams has some typing issues using onBeforeSelect etc.

Reproducer

No response

PrimeReact version

8.4.0

React version

18.x

Language

ALL

Build / Runtime

Create React App (CRA)

Browser(s)

No response

Steps to reproduce the behavior

No response

Expected behavior

No response
@melloware melloware added Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible Typescript Issue or pull request is *only* related to TypeScript definition Core Team Issue or pull request has been *opened* by a member of Core Team and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Sep 3, 2022
@melloware melloware self-assigned this Sep 3, 2022
@melloware melloware added this to the 8.5.0 milestone Sep 3, 2022
melloware added a commit to melloware/primereact that referenced this issue Sep 3, 2022
@melloware
Fix primefaces#3235: FileUpload proper typing of onSelect event
3b11e7d
@melloware melloware mentioned this issue Sep 3, 2022
Merged
@mertsincan mertsincan added the Type: Bug Issue contains a defect related to a specific component. label Sep 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@melloware melloware

Labels
Core Team Issue or pull request has been *opened* by a member of Core Team Type: Bug Issue contains a defect related to a specific component. Typescript Issue or pull request is *only* related to TypeScript definition
Projects
None yet
Milestone
8.5.0
Development

Successfully merging a pull request may close this issue.

Fix #3235: FileUpload proper typing of onSelect event melloware/primereact
2 participants
@melloware @mertsincan