Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FileUpload: removing the "multiple" tag drag and drop #2782

Closed
FrootLoopsR opened this issue Apr 21, 2022 · 2 comments · Fixed by #2786
Closed

FileUpload: removing the "multiple" tag drag and drop #2782

FrootLoopsR opened this issue Apr 21, 2022 · 2 comments · Fixed by #2786
Assignees
@melloware
Labels
Type: Bug Issue contains a defect related to a specific component.
Milestone
8.1.0

Comments

@FrootLoopsR
Copy link

[ x ] bug report
[ ] feature request
[ ] support request => Please do not submit a support request here, instead see https://forum.primefaces.org/viewforum.php?f=57

**Codesandbox **
https://codesandbox.io/s/busy-lamport-x6qnjf?file=/src/demo/FileUploadDemo.js

Current behavior
When removing the "multiple" tag drag and drop no longer works

Expected behavior
When dragging, capture only one file if 2 are dragged into the box
OR
Allow dragging one file into the box

  • Language: React JS
@melloware melloware added the Type: Bug Issue contains a defect related to a specific component. label Apr 21, 2022
@melloware melloware changed the title FileUpload FileUpload: removing the "multiple" tag drag and drop Apr 21, 2022
@melloware
Copy link
Member

Can you read this ticket: #2363

Its related and it fixed the exact opposite of what he is saying. I think the code was originally correct? or maybe it has broken again now with hooks.

melloware added a commit to melloware/primereact that referenced this issue Apr 21, 2022
@melloware
Fix primefaces#2782/primefaces#2363: FileUpload drag and drop
ed01587
@melloware melloware mentioned this issue Apr 21, 2022
Merged
@melloware melloware self-assigned this Apr 21, 2022
@melloware melloware added this to the 8.0.1 milestone Apr 21, 2022
@melloware
Copy link
Member

OK i see the issue and fixed it for both tickets correctly.

melloware added a commit that referenced this issue Apr 21, 2022
@melloware
Fix #2782/#2363: FileUpload drag and drop (#2786)
57991e2
@mertsincan mertsincan modified the milestones: 8.0.1, 8.1.0 Apr 26, 2022
@mertsincan mertsincan modified the milestones: 8.1.0, 8.1 May 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@melloware melloware

Labels
Type: Bug Issue contains a defect related to a specific component.
Projects
None yet
Milestone
8.1.0
Development

Successfully merging a pull request may close this issue.

Fix #2782/#2363: FileUpload drag and drop melloware/primereact
3 participants
@melloware @mertsincan @FrootLoopsR