Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dropdown 'optionDisabled' is wrongly typed as boolean #1921

Closed
yosbelms opened this issue Mar 30, 2021 · 3 comments
Closed

Dropdown 'optionDisabled' is wrongly typed as boolean #1921

yosbelms opened this issue Mar 30, 2021 · 3 comments
Assignees
@mcandu
Labels
Type: Bug Issue contains a defect related to a specific component.
Milestone
6.3.0

Comments

@yosbelms
Copy link 

[x] bug report
[ ] feature request
[ ] support request => Please do not submit support request here, instead see https://forum.primefaces.org/viewforum.php?f=57

Current behavior
Dropdown optionDisabled prop is typed as boolean

Expected behavior
Dropdown optionDisabled prop should be typed as string

  • React version:
    17

  • PrimeReact version:
    6.2.1

  • Language: TypeScript 4
@mcandu mcandu closed this as completed in bbe2d28 Mar 31, 2021
@yosbelms
Copy link
Author

@mcandu Typescript typing also needs update

@mcandu mcandu self-assigned this Apr 1, 2021
@mcandu mcandu added this to the 6.2.2 milestone Apr 1, 2021
mcandu added a commit that referenced this issue Apr 1, 2021
@mcandu
Refactor #1921 - Dropdown type update on ts file
e2b5803
@mcandu
Copy link
Contributor

mcandu commented Apr 1, 2021

I've updated it too. Thank you for your attention.

@mcandu mcandu added the Type: Bug Issue contains a defect related to a specific component. label Apr 1, 2021
@yosbelms
Copy link
Author

yosbelms commented Apr 1, 2021

Awesome work, thank you for the fast response!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mcandu mcandu

Labels
Type: Bug Issue contains a defect related to a specific component.
Projects
None yet
Milestone
6.3.0
Development

No branches or pull requests
2 participants
@yosbelms @mcandu