-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OrderList: Drag & drop is not working #1883
Comments
Replication and potential fix: Can confirm the issue on primereact 6.5.0 as well, Windows 10, Google Chrome Version 92.0.4515.159 (Official Build) (64-bit) Both my code and the example on the PrimeReact demo page seem to be affected by this issue https://primefaces.org/primereact/showcase/#/orderlist I did some further investigation and it appears that the element ".p-orderlist-droppoint" has a height of zero, so there's no physical drop point when dragging the item. When I set a height such as 20px to .p-orderlist-droppoint, the drag and drop functionality works again, both for the official demo and on my local project. Hopefully this helps out. Edit - Did some more testing, and while adding a height to the droppoint makes it possible to drag and drop an item, the resulting ordering of the items is inconsistent - items do not end up in the order they are dropped. I'm not sure if that should be a separate issue or if this is all connected. |
Note: Same component works in primeng |
Any news on when this fix will be implemented? |
I just pulled the most recent version of this and it has not yet been fixed. As noted, it does work in PrimeNG and PrimeFaces for JSF. Is there an ETA on this, please? |
If you can look at PrimeNG or PrimeVue that is working and submit a PR that would be awesome! |
I can confirm this is still not working. Sample sandbox (copied from demo site and updated with latest primereact/primeflex versions): https://codesandbox.io/s/zealous-feather-146ihq?file=/src/demo/OrderListDemo.js |
Yep no one has submitted any PR or fix. |
I fixed both the drag and drop and the problem where the drop point was off by 1. |
Codesandbox Case (Bug Reports)
Please fork the codesandbox below and create a case demonstrating your bug report. Issues without a codesandbox have much less possibility to be reviewed.
https://www.primefaces.org/primereact/showcase/#/orderlist
Current behavior
Cannot drag items on list although dragdrop prop is present.
Expected behavior
Should work like in PrimeNG: https://www.primefaces.org/primeng/showcase/#/orderlist
Minimal reproduction of the problem with instructions
Just enter the documentation page of OrderList
Please tell us about your environment:
Windows 10
whatever version is on your website
whatever version is on your website, probably 6.2.1 now
Browser:
Chrome 89.0.4389.82
Language:
es6
The text was updated successfully, but these errors were encountered: