Refactor #36

primefaces · Jul 3, 2017 · c2f025a · c2f025a
1 parent 489fb49
commit c2f025a
Showing 1 changed file with 14 additions and 10 deletions.
diff --git a/src/components/rating/Rating.js b/src/components/rating/Rating.js
@@ -28,11 +28,14 @@ export class Rating extends Component {
     rate(event, i){
         if(!this.props.readonly&&!this.props.disabled) {
             var _value = (i + 1);
-            this.props.onChange({
-                originalEvent: event,
-                value: _value
-            });
-            this.setState({value: _value});
+
+            if(_value !== this.state.value) {
+                this.props.onChange({
+                    originalEvent: event,
+                    value: _value
+                });
+                this.setState({value: _value});
+            }
         }
         event.preventDefault();        
     }
@@ -56,11 +59,12 @@ export class Rating extends Component {
         }
     }
 
-    componentWillReceiveProps(nextProps) {
-        var newValue = nextProps.value;
-        if (newValue !== this.state.value) {
-            this.setState({value: newValue});
-        } 
+    shouldComponentUpdate(nextProps, nextState) {
+        if(nextState.value === this.state.value) {
+            return false;
+        }
+
+        return true;
     }
 
     render() {