Fix #5073: SelectButton: Add allowEmpty property

primefaces · Oct 10, 2023 · 4d7fc00 · 4d7fc00
1 parent 0b2cd55
commit 4d7fc00
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 2 deletions.
diff --git a/components/lib/selectbutton/SelectButton.js b/components/lib/selectbutton/SelectButton.js
@@ -1,9 +1,9 @@
 import * as React from 'react';
+import { PrimeReactContext } from '../api/Api';
 import { Tooltip } from '../tooltip/Tooltip';
 import { DomHandler, mergeProps, ObjectUtils } from '../utils/Utils';
 import { SelectButtonBase } from './SelectButtonBase';
 import { SelectButtonItem } from './SelectButtonItem';
-import { PrimeReactContext } from '../api/Api';
 
 export const SelectButton = React.memo(
     React.forwardRef((inProps, ref) => {
@@ -23,7 +23,7 @@ export const SelectButton = React.memo(
 
             let selected = isSelected(event.option);
 
-            if (selected && !props.unselectable) {
+            if (selected && (!props.unselectable || props.allowEmpty)) {
                 return;
             }
 

diff --git a/components/lib/selectbutton/SelectButtonBase.js b/components/lib/selectbutton/SelectButtonBase.js
@@ -24,6 +24,7 @@ export const SelectButtonBase = ComponentBase.extend({
         tabIndex: null,
         multiple: false,
         unselectable: true,
+        allowEmpty: true,
         disabled: false,
         style: null,
         className: null,

diff --git a/components/lib/selectbutton/selectbutton.d.ts b/components/lib/selectbutton/selectbutton.d.ts
@@ -122,6 +122,11 @@ export interface SelectButtonProps extends Omit<React.DetailedHTMLProps<React.In
      * @defaultValue true
      */
     unselectable?: boolean | undefined;
+    /**
+     * Whether selection can not be cleared.
+     * @defaultValue true
+     */
+    allowEmpty?: boolean | undefined;
     /**
      * When present, it specifies that the element should be disabled.
      * @defaultValue false