Fix #5073: Refactor SelectButton behavior

Add deprecated tag for unselectable prop
primefaces · Oct 11, 2023 · 09e3349 · 09e3349
1 parent 2c201df
commit 09e3349
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/components/lib/selectbutton/SelectButton.js b/components/lib/selectbutton/SelectButton.js
@@ -23,7 +23,7 @@ export const SelectButton = React.memo(
 
             let selected = isSelected(event.option);
 
-            if (selected && (!props.unselectable || props.allowEmpty)) {
+            if (selected && !(props.unselectable || props.allowEmpty)) {
                 return;
             }
 

diff --git a/components/lib/selectbutton/selectbutton.d.ts b/components/lib/selectbutton/selectbutton.d.ts
@@ -119,6 +119,7 @@ export interface SelectButtonProps extends Omit<React.DetailedHTMLProps<React.In
     multiple?: boolean | undefined;
     /**
      * Whether selection can be cleared.
+     * @deprecated Use 'allowEmpty' property instead.
      * @defaultValue true
      */
     unselectable?: boolean | undefined;
-Original file line number
+Diff line change
@@ Expand Up / @@ -23,7 +23,7 @@ export const SelectButton = React.memo( @@
                 let selected = isSelected(event.option);
-                if (selected && (!props.unselectable || props.allowEmpty)) {
+                if (selected && !(props.unselectable || props.allowEmpty)) {
                     return;
                 }
@@ Expand Down @@