Issues primefaces#8647 primefaces#5663 remove message or toast by id

[sandrotonon]

Add a method to remove specific Toast/Message via MessageService

See #13600

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
primeng-ssr-test	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Sep 28, 2023 9:34am

1 Ignored Deployment

Name	Status	Preview	Comments	Updated (UTC)
primeng	⬜️ Ignored (Inspect)	Visit Preview		Sep 28, 2023 9:34am

[mertsincan]

Hi @sandrotonon,

Can't we use a more dynamic key instead of 'id'? For example;

// this.messageService.remove(<object_key>, <object_value>)

this.messageService.remove('id', 1);
---
this.messageService.remove('severity', 'success');

In addition, we have the removeMessage method that works with the index in the messages component. Maybe if we add this to toast, users can easily remove the message by giving the index of the message they want to delete to this method.

// this.messageService.remove(<object_index>)

const index = this.messages.findIndex((msg) => msg.id === 1);
this.messageService.remove(index);
---
const index = this.messages.findIndex((msg) => msg.severity === 'success');
this.messageService.remove(index);

WDYT?

[sandrotonon]

Hi @mertsincan,

i really like the more generic approach. This way users do have a lot more flexibility in managing their messages.

However the index-based idea doesn't seem to be that comfortable, because you'd have to keep track of all displayed messages to be able to know the indices of the ones you'd want to delete.

I've updated the PR to reflect the first approach:

messageService.remove(<object_key>, <object_value>)

[mertsincan]

Hi @sandrotonon,

Thanks a lot for the update! Frankly, I think we always need to filter all messages;
https://github.com/primefaces/primeng/pull/13599/files#diff-f1849731aed7bc226757a287fad99756df6389da4a30637bb84cf807a840e13fR179

That's why more feedback might be better for us. There is a similar desire in our other projects. That's why we can apply the most efficient solution for all of them.

[sandrotonon]

Frankly, I think we always need to filter all messages; https://github.com/primefaces/primeng/pull/13599/files#diff-f1849731aed7bc226757a287fad99756df6389da4a30637bb84cf807a840e13fR179

Hi @mertsincan, thanks for your feedback. But, what exactly do you mean?

[github-actions]

This pull request has been automatically marked as stale. If this pull request is still relevant, please leave any comment, and we will keep it open. We are sorry that we have not been able to prioritize reviewing it yet. Your contribution is very much appreciated.

[github-actions]

Closing this pull request after a prolonged period of inactivity. If this issue is still present in the latest release, please ask for this pull request to be reopened. Thank you for your understanding!

[martinkasa]

@cetincakiroglu can we revive this PR?

[mustafadalga]

@mertsincan Could you find a solution ?