Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Table documentation missing lazy load example #16745

Closed
JuncalLP opened this issue Nov 14, 2024 · 7 comments
Closed

Table documentation missing lazy load example #16745

JuncalLP opened this issue Nov 14, 2024 · 7 comments
Assignees
Labels
Component: Documentation Issue or pull request is related to Documentation
Milestone

Comments

@JuncalLP
Copy link

Describe the bug

On the docs page for table component, under the pagination section, there's a link for a lazy loading example, but it's broken. Thought this might be an issue with the beta docs but happens on v17 and v15 docs too.

imagen
imagen

Environment

Windows 10

Reproducer

No response

Angular version

18.2.8

PrimeNG version

18.0.0-beta.4

Build / Runtime

Angular CLI App

Language

TypeScript

Node version (for AoT issues node --version)

22.9

Browser(s)

Mozilla Firefox

Steps to reproduce the behavior

Navigate to https://v18.primeng.org/table#paginator and click on 'lazy loading'

Expected behavior

The lazy loading example should exist

@JuncalLP JuncalLP added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Nov 14, 2024
@joviga-dev
Copy link

up

@aboudard
Copy link

aboudard commented Nov 18, 2024

Yeah, the lazy section is here now, but it's place in the links on the right is off, and the text to describe it is the same as the virtualscroll :
image

https://v18.primeng.org/table#virtual-scroll-lazy
should be
https://v18.primeng.org/table#lazy
Problem with menu indentation obviously

@JuncalLP
Copy link
Author

Yeah, the lazy section is here now, but it's place in the links on the right is off, and the text to describe it is the same as the virtualscroll : image

https://v18.primeng.org/table#virtual-scroll-lazy should be https://v18.primeng.org/table#lazy Problem with menu indentation obviously

Are you sure about that? I think that the identation is right there, they're both examples of Virtual scroll, but on the first one the displayed elements array are eagerly loaded while on the second one are they're lazy loaded, however I'm interested in a lazy load example by itself, without Virtual scroll (handling paging, sorting, global search...).

@mertsincan mertsincan added Status: Pending Review Issue or pull request is being reviewed by Core Team and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Nov 19, 2024
@mertsincan mertsincan added this to the 18.0.0-rc.2 milestone Nov 19, 2024
@mertsincan mertsincan removed this from PrimeNG Nov 20, 2024
@aboudard
Copy link

Are you sure about that? I think that the identation is right there, they're both examples of Virtual scroll, but on the first one the displayed elements array are eagerly loaded while on the second one are they're lazy loaded, however I'm interested in a lazy load example by itself, without Virtual scroll (handling paging, sorting, global search...).

After checking, you are right, the v17 docs is organized the same way. I think that lazy should have its own section though, as you say. And for me, both are unrelated, the scroll event is simply going through the lazy mechanism.
That being said, even in v17 docs, the texts are already duplicated.

@aboudard
Copy link

Here is the page I was mentioning in v16:
https://www.primefaces.org/primeng-v16-lts/table#lazy-load
This page should be here. If I have time I might take a look at this for a PR.

@mehmetcetin01140 mehmetcetin01140 moved this from Discussion to Done in PrimeNG Dec 3, 2024
@mehmetcetin01140 mehmetcetin01140 closed this as completed by moving to Done in PrimeNG Dec 3, 2024
@mehmetcetin01140 mehmetcetin01140 added Component: Documentation Issue or pull request is related to Documentation and removed Status: Pending Review Issue or pull request is being reviewed by Core Team labels Dec 3, 2024
@joviga-dev
Copy link

@mehmetcetin01140 Does removing the hyperlink to the broken url really fixes the problem of the lazy loading example not existing?

@aboudard
Copy link

aboudard commented Dec 5, 2024

Yeah, I really doubt this commit would fix the problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Documentation Issue or pull request is related to Documentation
Projects
Status: Done
Development

No branches or pull requests

6 participants