Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AutoComplete: Fixed alignment #39

Merged

Conversation

SoyDiego
Copy link
Contributor

@SoyDiego SoyDiego commented Aug 26, 2023

Adding this line, fix the alignment issue primefaces/primeng#13532.

CURRENTLY

autocomplete problem

AFTER SOLUTION

autocomplete fixed

@mertsincan mertsincan linked an issue Sep 5, 2023 that may be closed by this pull request
@mertsincan mertsincan merged commit 279e55f into primefaces:main Sep 5, 2023
@mertsincan
Copy link
Member

Thanks a lot for your contribution!

@mertsincan
Copy link
Member

Sorry for the confusion! I reverted this PR. You need to fix the alignment issues in the core.

Best Regards,

@SoyDiego
Copy link
Contributor Author

SoyDiego commented Sep 8, 2023

Sorry for the confusion! I reverted this PR. You need to fix the alignment issues in the core.

Best Regards,

Hi Mert, I don't know how I need to continue with this issue.
I wrote in Discord (ZeR0ByTe) but maybe you are busy. I will write here if someone knows the reply.

Always when I did PRs, I changed there but now I realized that the styles are not equal for example in the next screenshot:

image

  1. ON THE LEFT primeng-sass-theme project with SASS has the class margin-left
  2. ON THE RIGHT primeng project has not margin-left and also has cursor.

Now when we have problems with styles only is necessary update primeng project?

I asking because I will do this two issues and with your comment I have doubts now:
primefaces/primeng#13617
primefaces/primeng#13532

I'm blocked until know how is the correct way.

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[AutoComplete] p-autocomplete-token-icon alignment issue
3 participants