prettier config default values

[gko]

Hello,

Thank you very much for plugin. I use it every day and love it! ❤️

I wanted to ask whether it's really necessary to set the default values for prettier within the plugin:

vim-prettier/plugin/prettier.vim

Lines 63 to 136 in 7a6fddd

	let g:prettier#config#print_width = get(g:, 'prettier#config#print_width', 'auto')
	" number of spaces per indentation level: a number or 'auto' (use
	" softtabstop)
	" default: 'auto'
	" See more: https://prettier.io/docs/en/options.html#tab-width
	let g:prettier#config#tab_width = get(g:,'prettier#config#tab_width', 'auto')
	" use tabs instead of spaces: true, false, or auto (use the expandtab setting).
	" default: 'auto'
	" See more: https://prettier.io/docs/en/options.html#tabs
	let g:prettier#config#use_tabs = get(g:,'prettier#config#use_tabs', 'auto')
	" flow|babylon|typescript|css|less|scss|json|graphql|markdown or empty string
	" (let prettier choose).
	" default: ''
	" See more: https://prettier.io/docs/en/options.html#parser
	let g:prettier#config#parser = get(g:,'prettier#config#parser', '')
	" cli-override|file-override|prefer-file
	" default: 'file-override'
	" See more: https://prettier.io/docs/en/cli.html#--config-precedence
	let g:prettier#config#config_precedence = get(g:, 'prettier#config#config_precedence', 'file-override')
	" always|never|preserve
	" default: 'preserve'
	" See more: https://prettier.io/docs/en/options.html#prose-wrap
	let g:prettier#config#prose_wrap = get(g:, 'prettier#config#prose_wrap', 'preserve')
	" css|strict|ignore
	" default: 'css'
	" See more: https://prettier.io/docs/en/options.html#html-whitespace-sensitivity
	let g:prettier#config#html_whitespace_sensitivity = get(g:, 'prettier#config#html_whitespace_sensitivity', 'css')
	" print semicolons
	" default: 'true'
	" See more: https://prettier.io/docs/en/options.html#semicolons
	let g:prettier#config#semi = get(g:,'prettier#config#semi', 'true')
	" Use single quotes instead of double quotes.
	" default: 'false'
	" See more: https://prettier.io/docs/en/options.html#quotes
	let g:prettier#config#single_quote = get(g:,'prettier#config#single_quote', 'false')
	" print spaces between brackets
	" default: 'true'
	" See more: https://prettier.io/docs/en/options.html#bracket-spacing
	let g:prettier#config#bracket_spacing = get(g:,'prettier#config#bracket_spacing', 'true')
	" put > on the last line instead of new line
	" default: 'false'
	" See more: https://prettier.io/docs/en/options.html#jsx-brackets
	let g:prettier#config#jsx_bracket_same_line = get(g:,'prettier#config#jsx_bracket_same_line', 'false')
	" avoid wrapping a single arrow function param in parens
	" avoid|always
	" default: 'always'
	" See more: https://prettier.io/docs/en/options.html#arrow-function-parentheses
	let g:prettier#config#arrow_parens = get(g:,'prettier#config#arrow_parens', 'always')
	" Define the flavor of line endings
	" lf|crlf|cr|all
	" defaut: 'lf'
	let g:prettier#config#end_of_line = get(g:, 'prettier#config#end_of_line', 'lf')
	" Print trailing commas wherever possible when multi-line.
	" none|es5|all
	" default: 'es5'
	" See more: https://prettier.io/docs/en/options.html#trailing-commas
	let g:prettier#config#trailing_comma = get(g:,'prettier#config#trailing_comma', 'es5')
	" restrict itself to only format files that contain a special comment @prettier or @format
	" See more: https://prettier.io/docs/en/options.html#require-pragma
	let g:prettier#config#require_pragma= get(g:, 'prettier#config#require_pragma', 'false')

The defaults that are present in the plugin are for prettier 2.x, so if you happen to work on a project with prettier 1.9 and forget to set arrow-parens to avoid in your config it will become always and then you will have conflicts with eslint.

Do you think that we probably should not pass the option at all if its value is not specified in prettier config and user .vimrc?

[CGamesPlay]

I would also love it if this plugin didn't force a set of options and just let prettier do its own thing. In the mean time, I drafted this workaround:

if prettier#PrettierCli('--version') < '2.0'
  let g:prettier#config#arrow_parens = 'avoid'
end

[tomgrim]

The Readme states:

Note: vim-prettier default settings differ from prettier intentionally.

It would be good to know why this is the case. I found this behaviour surprising.

[michaeljones]

I have been caught out today but vim-prettier using my shiftwidth instead of using the prettier default for tabWidth. I'd be grateful if there was an option to use default as a config value that basically means "don't set it and leave it to whatever prettier wants to do". Perhaps with time I'll adjust my vim to fall inline with the prettier settings but it as been confusing though I can see it is clearly documented.

This is mostly happening because my new team seems to be relying on prettier defaults for a lot so there is no config but my vim setup is old and crufty and so has some file type plugin settings lurking around which don't match prettier and I'd rather the prettier output matched my team and then I could bring my editor inline when I wanted but save in the knowledge that my code fits the team, rather than have the prettier output match my editor and have to bring my editor inline with the team straight away.

Though typing this out, it all sounds a bit subjective. I was just caught out and had to start printing out the command that vim-prettier was running to understand it all.

Thanks for the project though :)

[gaving]

Yeah, a little confused myself as to why there are defaults.

Had to add:-

let g:prettier#config#tab_width = '2'
let g:prettier#config#print_width = '80'

To get it to play nice with eslint at this end. Prettier 2.2.1.

[ojohnny]

The fact that the saved files are not guaranteed to pass prettier --check is a deal-breaking bug for me, unfortunately. Which is a shame, because the plugin works great otherwise!

[samuel-buuk]

I've also found this to be a bit of an issue. It looks like we will have to add a config file to our project to set the defaults to whatever prettier is using or alternatively I have to modify my vim configs. I agree with @michaeljones that an option to just use default prettier settings would be preferable if this behaviour is required for others.

[CGamesPlay]

Probably worth pointing out that the official Prettier website also recommends using ALE to handle the rewriting. I've dropped this plugin and switched to it successfully. I wish that ALE had a sync mode, but the experience isn't bad and it does use the proper prettier configuration.

https://prettier.io/docs/en/vim.html#alehttpsgithubcomdense-analysisale

[twm]

You can set it to ignore the CLI configuration options in favor of your .prettierrc like this:

let g:prettier#config#config_precedence = 'prefer-file'