Fix prettier and other rules working at the same time #360
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dartess
commented
Jul 1, 2024
| @@ -182,7 +182,7 @@ const ruleFunction = (expectation, options, context) => { | |||
| insertText + | |||
| rawData.substring(difference.offset + deleteText.length) | |||
| ); | |||
| }, root.source.input.css); | |||
| }, source); | |||
There was a problem hiding this comment.
it looks like the prettier always runs on the raw input data, and not on the current version of the code (some rules may have done their job before the prettier).
dartess
commented
Jul 1, 2024
| @@ -107,6 +106,7 @@ const ruleFunction = (expectation, options, context) => { | |||
|
|
|||
| let prettierSource; | |||
|
|
|||
| const source = root.toString(); | |||
There was a problem hiding this comment.
This is where asynchrony comes into play. Previously, this code was executed before some asynchronous operations, and it turned out that first this plugin gets the code, after that other rules made changes to the code, and after that the prettier was launched on the old version of the code. Now this code works synchronously because it runs after all asynchronous operations.
BPScott
approved these changes
Jul 13, 2024
BPScott
pushed a commit
that referenced
this pull request
Jul 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closed #354
I'm not a stylelint guru. But at least I added a test demonstrating the bug, and added a description of the problem that this bug causes.