Add an option to suppress popping up the output panel for a failed run

[orta]

Should be enough to close #168

Allows a user to opt out of the output channel being popped up, TBH it might be worth thinking about making this be the default and allow opting in to showing the output channel on an error. I can't imagine that the errors are inside prettier any more, and I'm willing to bet that VS Code makes it pretty obvious that your source code isn't compiling correctly. Plus you'll see the "prettier x" in the bottom right.

[CiGit]

Hey, thanks for your PR.

I don't think an option for that is a good move.
We could discuss to remove the automatic opening. It's definitely not in prettier's scope to lint your code. prettier : X may be enough to say something went wrong
I'll let @RobinMalfait decide on that one ;-)

As I'm working on #243 there are things which will have to change anyway. (Or I'll have to do some dirty checks to keep the same functionalities)

[RobinMalfait]

Hey! Thanks for the PR!

I have been annoyed by the popup itself, especially because it doesn't close when the formatting is correct.

The changes I have requested should result in remove some code (Yay!)

Thanks for the PR!

[RobinMalfait]

What I would do for this PR is the following:

• Do not add an extra option (options are not fun and hard to maintain)
• Always write to the output log (I think this is already the case)
• Do not show the popup on first error

[orta]

Alright, agreed - this does that 👍 now, much simpler

[RobinMalfait]

Perfect!
@CiGit can you verify? Code LGTM

[CiGit]

@RobinMalfait

Always write to the output log (I think this is already the case)

did you mean https://github.com/prettier/prettier-vscode/blob/master/src/PrettierEditProvider.ts#L161 ?
onWorkspaceRootChange is quite embarrassing for #243

Code looks good.
+2 -13 lines is a really good fix

[RobinMalfait]

I was talking about

prettier-vscode/src/PrettierEditProvider.ts

Line 158 in 844ecd6

addToOutput(warningMessage);

I didn't know the warning message was still used?

[CiGit]

Well it seems to be used. And It can be removed I think.

[orta]

^ I can't tell if this is you two asking me to amend this PR

[RobinMalfait]

@orta Go ahead 😄

[CiGit]

I'm fine with that. We can remove last warning in a later PR (I'm actually working on it)

[RobinMalfait]

@CiGit Cool, thanks for the PR @orta !