feat: initial support for prettier-stylelint #218
Conversation
|
Thanks for that PR and your prettier-stylelint. |
|
stylelint doesnt have a sync api, i can create a safeExecutionAsync instead and leave everything abstracted in the utils |
|
This is also a solution. Make |
|
@CiGit does this seem good to you ? |
|
Yup, I prefer. asking @RobinMalfait for a review of About prettier-stylelint, which prettier/ stylelint version does it pickup? |
src/errorHandler.ts
Outdated
| addToOutput(addFilePath(err.message, fileName)); | ||
| updateStatusBar('Prettier: $(x)'); | ||
|
|
||
| console.log(err); |
There was a problem hiding this comment.
Maybe we need to remove this line
There was a problem hiding this comment.
Hmm, now that I'm thinking about it, the safeExecution has a lot of duplicated code.
There was a problem hiding this comment.
Ofc damn .. I'll remove that
|
@CiGit for now the bundled version, but I'll be fixing that in a near future |
|
@RobinMalfait pushed a commit removing the console log |
|
My concerns are how often do you expect it to be updated, until it has all the feature you'd like ? |
|
i dont expect to have that many releases from now on. besides ill keep sending PR's here for each new release. |
|
@CiGit with this last commit your concerns should be addressed |
|
Please resolve conflicts, I'll merge after. |
|
And update the readme please :-) |
… into feat/support-prettier-stylelint
|
Thanks ! |
|
Is there some way to configure this to run over JS files? Use case: styled-components. The regular stylelint extension for vscode has a config option "stylelint.additionalDocumentSelectors": [
"javascriptreact",
"javascript"
]Happy to make an issue in the appropriate repo, but thought i'd ask here given this was the integration point |
this adds initial support for prettier-stylelint, im still adding features but the basic stuff at least for the extension works well.
please keep in mind that i don't do ts or vscode extensions much :) be gentle
ref #207