-
-
Notifications
You must be signed in to change notification settings - Fork 460
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade builtin Prettier to 3.x again #3142
Comments
@ntotten Can you add pre-release version to test Prettier 3.x? https://code.visualstudio.com/api/working-with-extensions/publishing-extension#prerelease-extensions |
It's not too late after #3099. |
+1 |
This issue has been labeled as stale due to inactivity. Reply to keep this issue open. |
Can be fixed if this is fixed |
Could someone try VS Code Insiders? It now supports ESM by upgrading Electron to 28. |
* Nearly all, except some packages that have migrated to ESM and are more diffult to update, in addition to - eslint, for which typescript-eslint doesn't support yet [1[, and - prettier, for which the associated extension remains behind [2] This fixes #1180 [3]. [1] typescript-eslint/typescript-eslint#8211 [2] prettier/prettier-vscode#3142 [3] #1180
* Nearly all, except some packages that have migrated to ESM and are more diffult to update, in addition to - eslint, for which typescript-eslint doesn't support yet [1[, and - prettier, for which the associated extension remains behind [2] This fixes #1180 [3]. [1] typescript-eslint/typescript-eslint#8211 [2] prettier/prettier-vscode#3142 [3] #1180
This issue has been labeled as stale due to inactivity. Reply to keep this issue open. |
microsoft/vscode#201935 was fixed |
We may have to wait for the fix of microsoft/vscode-loader#56 |
This may also be a blocker: microsoft/vscode#130367 |
Prettier 3.x is released for a long time, so do this issue. Add some mention to the README (maybe just update the "Prettier Version 3" part) or a notice in the extension might be helpful. |
In VS Code Exploration available from microsoft/vscode#160416 (comment), the execution of
Just the bundle process is incomplete. There are no other JS files than those whose names are Update: a newer build is available: microsoft/vscode#226399 (comment) Update: ESM is enabled in VS Code since 1.94: |
1.94 has been stabilized. |
This issue has been labeled as stale due to inactivity. Reply to keep this issue open. |
Waiting for requireESM in Electron Node |
Is your feature request related to a problem? Please describe.
Prettier 3 has been released but this extension pins it to 2.x due to #3099 #3098
I can't enable this extension globally due to prettier/prettier#6385. (I'm the author of prettier/prettier#11597)
Describe the solution you'd like
Upgrade builtin Prettier to 3.x again
Describe alternatives you've considered
Install Prettier 3.x or a backport plugin in every repositories
Additional context
The text was updated successfully, but these errors were encountered: