Changed type1 and type2 to be consistent #2021
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The constants are redundant imo. Functionally, there's not difference in battle between a Roxk/Ground and Ground/Rock mon, just the order of the types. Plus, if someone wants to add more types to the array, they shouldn't need to update the enum. |
AsparagusEduardo
approved these changes
Aug 6, 2024
github-actions bot
pushed a commit
to s744865306fang/pokeemerald
that referenced
this pull request
Aug 7, 2024
This was referenced Aug 7, 2024
issueWithLife
pushed a commit
to issueWithLife/pokeemerald
that referenced
this pull request
Sep 2, 2024
* Changed type1 and type2 in gBattleMons to match gSpeciesInfo * Changed monType1 and monType2 to monTypes to match gSpeciesInfo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
* Added constantsTYPE_PRIMARYandTYPE_SECONDARY.type1totypes[0].type2totypes[1]Discord contact info
psf