Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added fix to Keep the Camera from Making Waves #1987

Merged

Conversation

pkmnsnfrn
Copy link
Contributor

@pkmnsnfrn pkmnsnfrn commented Apr 5, 2024

Implements https://github.com/pret/pokeemerald/wiki/Keep-the-Camera-from-Making-Waves as a BUGFIX, stolen from @tustin2121 with permission. I opted against the invisible option as the camera seems like the more applicable version.

Description

BUGFIX On BUGFIX Off
on off

Testing

// data/maps/InsideOfTruck/scripts.inc
InsideOfTruck_EventScript_MovingBox::
+    warp MAP_PETALBURG_CITY,0
	msgbox InsideOfTruck_Text_BoxPrintedWithMonLogo, MSGBOX_SIGN
	end

// data/maps/PetalburgCity/scripts.inc
PetalburgCity_EventScript_Boy::
+    special SpawnCameraObject
+    applymovement OBJ_EVENT_ID_CAMERA, WalkAway
	lock
	faceplayer
	msgbox PetalburgCity_Text_WaterReflection, MSGBOX_DEFAULT
	closemessage
	applymovement LOCALID_BOY, Common_Movement_FaceOriginalDirection
	waitmovement 0
	release
	end

+ WalkAway:
+    walk_down
+    walk_down
+    walk_down
+    walk_left
+    walk_left
+    walk_left
+    step_end

Discord contact info

I am pkmnsnfrn.

@GriffinRichards GriffinRichards merged commit af0165a into pret:master Apr 11, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants