Macros for keeping .partyFlags, .partySize, and .party in sync #1717
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces four macros for keeping
.partyFlags
,.partySize
, and.party
in sync, e.g.:The motivation is that new people often forget or don't know that they have to update
.partyFlags
and come to #pokeemerald asking about why their trainer's party is acting weirdly.We had a quick discussion on Discord, and of the three replies I received at time of submitting this PR, they were neutral-to-positive on the
.party = NO_ITEM_DEFAULT_MOVES(sParty_Sawyer1),
syntax which is a bit gross, because we hide the initializations of.partySize
and.partyFlags
inside it; but I believe this design is better than having the macro also include.party
because then that line wouldn't have a member name and that sticks out in a bad way.For the benefit of people who find this PR because of a horrific merge conflict, I automated the changes in
src/data/trainers.h
with: