Add Oracle fetchSize#3775
Closed
eskabetxe wants to merge 1 commit intotrinodb:masterfrom
eskabetxe:oracleFetchSize
Closed
Add Oracle fetchSize#3775eskabetxe wants to merge 1 commit intotrinodb:masterfrom eskabetxe:oracleFetchSize
eskabetxe wants to merge 1 commit intotrinodb:masterfrom
eskabetxe:oracleFetchSize
Conversation
electrum
approved these changes
May 27, 2020
presto-oracle/src/test/java/io/prestosql/plugin/oracle/TestOracleConfig.java
Outdated
Show resolved
Hide resolved
Member
|
Why do we need this configurable? I am not convinced, but more importantly, it's not obvious, so we should capture the reasoning in the code comment. |
Contributor
|
some tables are wide, some are narrow. some are all string, some are timestamp. some db instance is higher spec |
Member
|
@tooptoop4 This is catalog-level property. Do you have catalogs with only wide or only narrow tables? |
Contributor
|
catalog level choice is better than no choice |
Member
|
Please answer my second question when you have time. |
tooptoop4
approved these changes
Jun 17, 2021
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this allow to configure the fetch size of oracle connection
@tooptoop4 your request