Add RFC to support custom schemas in native sidecar function registry#50
Conversation
Joe-Abraham
force-pushed
the
customNamespace
branch
from
35d1130 to
0837366
Compare
prestodb-ci
requested review from
a team and
anandamideShakyan
and removed request for
a team
Joe-Abraham
force-pushed
the
customNamespace
branch
from
0837366 to
e533bcb
Compare
pdabre12
requested review from
aditi-pandit,
amitkdutta,
rschlussel and
tdcmeehan
tdcmeehan
left a comment
tdcmeehan
left a comment
There was a problem hiding this comment.
LGTM, just one question
| ``` | ||
|
|
||
| ## Implementation Details | ||
| - Functions are registered in Velox as `catalog.schema.function_name`. |
There was a problem hiding this comment.
I suppose built-ins do not have a namespace?
There was a problem hiding this comment.
They do, they will be under the namespace specified by the config property presto.default-namespace.
pdabre12
left a comment
pdabre12
left a comment
There was a problem hiding this comment.
Thanks @Joe-Abraham .
Please change the RFC title to this Add RFC to support custom schemas in native sidecar function registry or something similar.
RFC-0017-Support-custom-schemas-in-native-sidecar-function-registry.md
Outdated
Show resolved
Hide resolved
| ``` | ||
|
|
||
| ## Implementation Details | ||
| - Functions are registered in Velox as `catalog.schema.function_name`. |
There was a problem hiding this comment.
They do, they will be under the namespace specified by the config property presto.default-namespace.
Joe-Abraham
force-pushed
the
customNamespace
branch
from
e533bcb to
9a9c611
Compare
Joe-Abraham
changed the title
|
How does the function resolution handle the case when the native worker registers functions under a namespace and the coordinator registers functions under the same function namespace? I wonder if only one function catalog can be mapped to exactly one namespace manager. |
| # etc/function-namespace/mycatalog.properties | ||
| function-namespace-manager.name=native | ||
| function-implementation-type=CPP | ||
| supported-function-languages=CPP |
There was a problem hiding this comment.
What do these 2 fields mean and what are the possible options for them ?
There was a problem hiding this comment.
function-implementation-type - Indicates the language in which functions in this namespace are implemented. And it can take the following values
supported-function-languages - Languages supported by the namespace manager.
I don't see any pre-list of values this config could take, In current codebase cpp, sql and java are used
There was a problem hiding this comment.
However, I think the NativeFunctionNamespace manager only supports CPP.
Only one function catalog can map to one namespace manager, native worker functions use a parallel system through BuiltInFunctionHandle with different kinds to coexist with coordinator functions without catalog collision. |
Joe-Abraham
force-pushed
the
customNamespace
branch
from
9a9c611 to
2e7d511
Compare
6 participants
No description provided.