Add RFC for plugin connectors #49
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prestodb-ci
requested review from
a team,
NivinCS and
nishithakbhaskaran
and removed request for
a team
6 tasks
majetideepak
approved these changes
Oct 10, 2025
Contributor
majetideepak
left a comment
majetideepak
left a comment
There was a problem hiding this comment.
The proposal looks good to me. Making the protocol layer pluggable is the missing piece for connector extensibility in Presto C++. Glad to see that happening here!
RFC-0019-connector-plugins.md
Outdated
| void deserialize(const std::string& binary, | ||
| std::shared_ptr<ConnectorSplit>& split) const override { | ||
| // Deserialize binary into protocol-specific type | ||
| ArrowFlightSplit protocolSplit; |
Contributor
There was a problem hiding this comment.
This code block is not correct. Maybe copy a subset of the TpchConnectorProtocol code from your PR.
aditi-pandit
approved these changes
Oct 17, 2025
tdcmeehan
added a commit
to prestodb/presto
that referenced
this pull request
Nov 5, 2025
…ion codecs (#26257) ## Description Add support for custom connector-provided serialization codecs ## Motivation and Context This will allow plugin connectors to be written in C++. RFC: prestodb/rfcs#49 End to end changes migrating TPCH to the new framework: #26026 ## Impact No immediate impact ## Test Plan Included tests ## Contributor checklist - [ ] Please make sure your submission complies with our [contributing guide](https://github.com/prestodb/presto/blob/master/CONTRIBUTING.md), in particular [code style](https://github.com/prestodb/presto/blob/master/CONTRIBUTING.md#code-style) and [commit standards](https://github.com/prestodb/presto/blob/master/CONTRIBUTING.md#commit-standards). - [ ] PR description addresses the issue accurately and concisely. If the change is non-trivial, a GitHub Issue is referenced. - [ ] Documented new properties (with its default value), SQL syntax, functions, or other functionality. - [ ] If release notes are required, they follow the [release notes guidelines](https://github.com/prestodb/presto/wiki/Release-Notes-Guidelines). - [ ] Adequate tests were added if applicable. - [ ] CI passed. ## Release Notes ``` == NO RELEASE NOTE == ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.