Skip to content

Use varchar for MySQL/PostgreSQL native JSON fields. #7506

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
stewartpark wants to merge 1 commit into from
Closed

Use varchar for MySQL/PostgreSQL native JSON fields. #7506

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 9 additions & 9 deletions presto-base-jdbc/src/main/java/com/facebook/presto/plugin/jdbc/BaseJdbcClient.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -487,14 +487,6 @@ protected Type toPrestoType(int jdbcType, int columnSize)
case Types.CHAR:
case Types.NCHAR:
return createCharType(min(columnSize, CharType.MAX_LENGTH));
case Types.VARCHAR:
case Types.NVARCHAR:
case Types.LONGVARCHAR:
case Types.LONGNVARCHAR:
if (columnSize > VarcharType.MAX_LENGTH) {
return createUnboundedVarcharType();
}
return createVarcharType(columnSize);
case Types.BINARY:
case Types.VARBINARY:
case Types.LONGVARBINARY:
Expand All @@ -505,8 +497,16 @@ protected Type toPrestoType(int jdbcType, int columnSize)
return TIME;
case Types.TIMESTAMP:
return TIMESTAMP;
case Types.VARCHAR:
case Types.NVARCHAR:
case Types.LONGVARCHAR:
case Types.LONGNVARCHAR:
default:
if (columnSize > VarcharType.MAX_LENGTH) {
return createUnboundedVarcharType();
}
return createVarcharType(columnSize);
}
return null;
}

protected String toSqlType(Type type)
Expand Down