fix: Change default config.properties to instantiate a coordinator#27472
Merged
nishithakbhaskaran merged 1 commit intoprestodb:masterfrom Apr 1, 2026
Merged
fix: Change default config.properties to instantiate a coordinator#27472nishithakbhaskaran merged 1 commit intoprestodb:masterfrom
nishithakbhaskaran merged 1 commit intoprestodb:masterfrom
Conversation
Contributor
Reviewer's guide (collapsed on small PRs)Reviewer's GuideUpdate the default Presto config.properties to start a single-node coordinator instead of a resource manager-based deployment by toggling coordinator-related properties and removing resource-manager-specific settings. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Contributor
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- Given the switch from a resource manager to a coordinator, consider updating
node.id(currently ending withrm) to avoid confusing users about the node’s intended role. - You might want to keep the removed resource-manager-related properties in the sample config as commented-out examples so users can more easily configure a resource manager if needed.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Given the switch from a resource manager to a coordinator, consider updating `node.id` (currently ending with `rm`) to avoid confusing users about the node’s intended role.
- You might want to keep the removed resource-manager-related properties in the sample config as commented-out examples so users can more easily configure a resource manager if needed.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
tdcmeehan
approved these changes
Mar 31, 2026
Contributor
|
Thanks for the fix @infvg . |
15 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR accidentally changed the default config.properties: https://github.com/prestodb/presto/pull/26635/changes
This changes it back.