Skip to content

misc: Use folly eventcount from folly/synchronization#27460

Merged
amitkdutta merged 1 commit intoprestodb:masterfrom
amitkdutta:tst23
Mar 31, 2026
Merged

misc: Use folly eventcount from folly/synchronization#27460
amitkdutta merged 1 commit intoprestodb:masterfrom
amitkdutta:tst23

Conversation

@amitkdutta
Copy link
Copy Markdown
Contributor

@amitkdutta amitkdutta commented Mar 30, 2026

== NO RELEASE NOTE ==

Summary by Sourcery

Tests:

  • Switch test includes from folly/experimental/EventCount.h to folly/synchronization/EventCount.h in native execution test files.

@amitkdutta amitkdutta requested review from a team as code owners March 30, 2026 04:21
@prestodb-ci prestodb-ci added the from:Meta PR from Meta label Mar 30, 2026
@sourcery-ai
Copy link
Copy Markdown
Contributor

sourcery-ai bot commented Mar 30, 2026

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Replaces usage of the deprecated experimental Folly EventCount header with the stable synchronization header in test files to align with the modern Folly API.

File-Level Changes

Change Details Files
Update Folly EventCount includes to use the synchronization header instead of the experimental header.
  • Replace inclusion of folly/experimental/EventCount.h with folly/synchronization/EventCount.h in PrestoExchangeSource-related tests
  • Replace inclusion of folly/experimental/EventCount.h with folly/synchronization/EventCount.h in TaskManager-related tests
presto-native-execution/presto_cpp/main/tests/PrestoExchangeSourceTest.cpp
presto-native-execution/presto_cpp/main/tests/TaskManagerTest.cpp

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@amitkdutta amitkdutta marked this pull request as draft March 30, 2026 04:21
Copy link
Copy Markdown
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@amitkdutta amitkdutta marked this pull request as ready for review March 31, 2026 14:57
@amitkdutta amitkdutta merged commit b516700 into prestodb:master Mar 31, 2026
86 of 88 checks passed
bibith4 pushed a commit to bibith4/presto that referenced this pull request Apr 1, 2026
```
== NO RELEASE NOTE ==
```

## Summary by Sourcery

Tests:
- Switch test includes from folly/experimental/EventCount.h to
folly/synchronization/EventCount.h in native execution test files.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

from:Meta PR from Meta

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants