refactor: Rename targetTableName to indexName

[skyelves]

Summary: Rename targetTableName to indexName

Differential Revision: D97415619

Summary by Sourcery

Enhancements:

• Rename CreateVectorIndexAnalysis target table identifier to indexName and propagate the new name through logical planning of vector index creation.

Release Notes

== NO RELEASE NOTE ==

[sourcery-ai]

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Refactors the vector index creation flow by renaming the target table identifier from targetTableName to indexName in the analysis model and logical planner, keeping behavior the same but clarifying semantics.

Class diagram for renamed indexName in CreateVectorIndexAnalysis

classDiagram
    class Analysis {
    }

    class CreateVectorIndexAnalysis {
        - QualifiedObjectName sourceTableName
        - QualifiedObjectName indexName
        - List~Identifier~ columns
        - Map~String,Expression~ properties
        - Optional~Expression~ updatingFor

        + CreateVectorIndexAnalysis(QualifiedObjectName sourceTableName, QualifiedObjectName indexName, List~Identifier~ columns, Map~String,Expression~ properties, Optional~Expression~ updatingFor)
        + QualifiedObjectName getSourceTableName()
        + QualifiedObjectName getIndexName()
        + List~Identifier~ getColumns()
        + Map~String,Expression~ getProperties()
        + Optional~Expression~ getUpdatingFor()
    }

    Analysis .. CreateVectorIndexAnalysis : contains

Loading

File-Level Changes

Change	Details	Files
Rename the vector index target table identifier from targetTableName to indexName throughout analysis and planning.	Rename CreateVectorIndexAnalysis field targetTableName to indexName and update constructor null-checks accordingly. Rename getter from getTargetTableName to getIndexName and update all call sites. Update LogicalPlanner to use the new getIndexName accessor when resolving connector ID and building ConnectorTableMetadata for the index.	presto-analyzer/src/main/java/com/facebook/presto/sql/analyzer/Analysis.java presto-main-base/src/main/java/com/facebook/presto/sql/planner/LogicalPlanner.java

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey - I've left some high level feedback:

• Now that targetTableName has been renamed to indexName, consider updating nearby variable names and comments such as // Build target table metadata with properties and targetTableMetadata to use index terminology for consistency and clarity.

Prompt for AI Agents

Please address the comments from this code review:

## Overall Comments
- Now that `targetTableName` has been renamed to `indexName`, consider updating nearby variable names and comments such as `// Build target table metadata with properties` and `targetTableMetadata` to use index terminology for consistency and clarity.

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[NivinCS]

Changes looks good to me

[aditi-pandit]

Thanks @skyelves