docs: Add TVF documentation in develop/table-functions#27367
Merged
steveburnett merged 1 commit intoprestodb:masterfrom Mar 24, 2026
Merged
docs: Add TVF documentation in develop/table-functions#27367steveburnett merged 1 commit intoprestodb:masterfrom
steveburnett merged 1 commit intoprestodb:masterfrom
Conversation
Contributor
Reviewer's guide (collapsed on small PRs)Reviewer's GuideAdds new developer documentation for table-valued functions (TVFs) and wires it into the existing developer and functions docs navigation, including a cross-reference from the table functions user docs. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Contributor
There was a problem hiding this comment.
Hey - I've found 1 issue
Prompt for AI Agents
Please address the comments from this code review:
## Individual Comments
### Comment 1
<location path="presto-docs/src/main/sphinx/develop/table-functions.rst" line_range="273-274" />
<code_context>
+Access control
+==============
+
+The access control for table functions can be provided both on system and connector
+level. It is based on the fully qualified table function name, which consists of
+the catalog name, the schema name, and the function name, in the syntax of
+catalog.schema.function.
</code_context>
<issue_to_address>
**suggestion (typo):** Clarify wording around "both on system and connector level".
Consider rephrasing to: "can be provided on both the system and connector levels."
```suggestion
The access control for table functions can be provided on both the system and connector
levels. It is based on the fully qualified table function name, which consists of
```
</issue_to_address>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
aditi-pandit
approved these changes
Mar 18, 2026
Contributor
aditi-pandit
left a comment
There was a problem hiding this comment.
Thanks @steveburnett
Contributor
Author
|
@tdcmeehan, please review when you can. Thanks! |
Contributor
Author
|
Note that the failing but not required CI check for the release note seems to be failing because of the Sourcery-added summary. "com.facebook.presto.release.tasks.GenerateReleaseNotesTask Bad release notes for PR #0: expect section header, found [Summary by Sourcery]" Perhaps the CI check needs to be revised to handle this. |
tdcmeehan
approved these changes
Mar 24, 2026
This was referenced Mar 31, 2026
15 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Building on the work in #27333 , this PR adds developer documentation for table value functions (TVF) based on the Trino documentation Table Functions.
Adds a cross-reference link in https://github.com/prestodb/presto/blob/master/presto-docs/src/main/sphinx/functions/table.rst to the new page.
Motivation and Context
Adds developer documentation for TVFs in Presto.
Impact
Documentation.
Test Plan
Local doc builds.
Contributor checklist
Release Notes
Summary by Sourcery
Add developer documentation for table value functions and cross-reference it from existing function documentation.
Documentation: