feat(client): Log "Running <query_id>..." in Presto cli in non-interactive mode#27359
Merged
spershin merged 1 commit intoprestodb:masterfrom Mar 18, 2026
Merged
feat(client): Log "Running <query_id>..." in Presto cli in non-interactive mode#27359spershin merged 1 commit intoprestodb:masterfrom
spershin merged 1 commit intoprestodb:masterfrom
Conversation
Summary: It is frustrating not to know the query ID, when yopu running a query from a file or an SQL statement. This fixes it. Differential Revision: D96955453
|
Contributor
Reviewer's guide (collapsed on small PRs)Reviewer's GuideLogs the query ID to the error channel when Presto CLI is running in non-interactive mode so users can see which query is executing. Sequence diagram for logging query ID in Presto CLI non-interactive modesequenceDiagram
actor User
participant PrestoCli
participant Query
participant StatusPrinter
participant ErrorChannel
participant QueryStatusInfo
User->>PrestoCli: runCliWithSqlOrFile()
PrestoCli->>Query: renderQueryOutput(out, outputFormat, interactive = false)
alt non_interactive_mode
Query->>Query: currentStatusInfo()
Query->>QueryStatusInfo: getId()
QueryStatusInfo-->>Query: queryId
Query->>ErrorChannel: printf(Running %s ..., queryId)
Query->>StatusPrinter: processInitialStatusUpdates(warningsPrinter)
else interactive_mode
Query->>StatusPrinter: printInitialStatusUpdates()
end
StatusPrinter-->>PrestoCli: initial status rendered
PrestoCli-->>User: stdout results, stderr shows Running queryId ...
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Contributor
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- Consider guarding the
client.currentStatusInfo().getId()call (or reusing an existing status object) to avoid potential null/empty IDs or additional RPCs at this early point in non-interactive execution.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Consider guarding the `client.currentStatusInfo().getId()` call (or reusing an existing status object) to avoid potential null/empty IDs or additional RPCs at this early point in non-interactive execution.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
arhimondr
approved these changes
Mar 18, 2026
This was referenced Mar 31, 2026
15 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
It is frustrating not to know the query ID, when yopu running a query
from a file or an SQL statement.
This fixes it.
Differential Revision: D96955453
Release Notes
Please follow release notes guidelines and fill in the release notes below.
Summary by Sourcery
Enhancements: