misc: Remove dead code in Iceberg connector

[amitkdutta]

Summary: Remove unused columnParseParameters in IcebergPrestoToVeloxConnector::toVeloxColumnHandle. The variable was computed for date types but never passed to the IcebergColumnHandle constructor, which doesn't accept it — it already hardcodes kDaysSinceEpoch internally.

== NO RELEASE NOTE ==

[sourcery-ai]

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Makes TypeParser’s cached type map thread-safe using folly::Synchronized and removes unused date parsing parameter code in the IcebergPrestoToVeloxConnector.

Sequence diagram for TypeParser::parse with thread-safe cache access

sequenceDiagram
  actor Thread
  participant TypeParser
  participant Cache as SynchronizedCache
  participant VeloxParser as PrestoSqlTypeParser

  Thread->>TypeParser: parse(text)
  TypeParser->>Cache: rlock()
  Cache-->>TypeParser: lockedCache
  TypeParser->>Cache: find(text)
  alt type_in_cache
    Cache-->>TypeParser: cached TypePtr
    TypeParser-->>Thread: TypePtr
  else type_not_in_cache
    TypeParser->>VeloxParser: parseType(text)
    VeloxParser-->>TypeParser: TypePtr result
    TypeParser->>Cache: wlock()
    Cache-->>TypeParser: lockedCache
    TypeParser->>Cache: insert(text, result)
    TypeParser-->>Thread: TypePtr result
  end

Loading

Class diagram for updated TypeParser thread-safe cache

classDiagram
  class TypeParser {
    +velox::TypePtr parse(std::string text) const
    -mutable folly::Synchronized<std::unordered_map<std::string, velox::TypePtr>> cache_
  }

  class SynchronizedCache {
    <<folly::Synchronized>>
    +std::unordered_map<std::string, velox::TypePtr> data
    +rlock() const
    +wlock()
  }

  class VeloxType {
    <<velox::TypePtr>>
  }

  TypeParser --> SynchronizedCache : uses cache_
  SynchronizedCache --> VeloxType : stores

Loading

File-Level Changes

Change	Details	Files
Make TypeParser cache thread-safe while preserving existing caching behavior.	Wrap the mutable unordered_map cache in folly::Synchronized to allow safe concurrent access from const parse() Use rlock() to look up existing cached entries without mutation and return early on hit Use wlock() to insert newly parsed types into the cache after calling prestosql::parseType Include folly/Synchronized.h and add brief documentation comments describing the TypeParser and its cache	presto-native-execution/presto_cpp/main/types/TypeParser.cpp presto-native-execution/presto_cpp/main/types/TypeParser.h
Remove unused date partition parsing parameter setup from IcebergPrestoToVeloxConnector.	Delete construction of HiveColumnHandle::ColumnParseParameters and the conditional date-specific partitionDateValueFormat assignment Leave type resolution via stringToType and IcebergColumnHandle construction unchanged	presto-native-execution/presto_cpp/main/connectors/IcebergPrestoToVeloxConnector.cpp

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey - I've left some high level feedback:

• In TypeParser::parse, you now take a read lock, release it, then take a write lock and unconditionally insert; consider a double-checked pattern under the write lock (re-check if the key was inserted while computing or use try_emplace) to avoid duplicate parsing and to keep the cache semantics consistent under contention.
• Holding the write lock while calling velox::functions::prestosql::parseType could serialize all parses; you might want to compute the type outside the write lock and then insert with a short critical section, accepting the possibility of benign duplicate parses.

Prompt for AI Agents

Please address the comments from this code review:

## Overall Comments
- In `TypeParser::parse`, you now take a read lock, release it, then take a write lock and unconditionally insert; consider a double-checked pattern under the write lock (re-check if the key was inserted while computing or use `try_emplace`) to avoid duplicate parsing and to keep the cache semantics consistent under contention.
- Holding the write lock while calling `velox::functions::prestosql::parseType` could serialize all parses; you might want to compute the type outside the write lock and then insert with a short critical section, accepting the possibility of benign duplicate parses.

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[kewang1024]

what is the performance implication for this new synchronization?

[amitkdutta]

Removed this change.

[aditi-pandit]

Thanks @amitkdutta