Skip to content

feat: Add documentation for CREATE VECTOR INDEX (#27332)#27332

Merged
skyelves merged 1 commit intoprestodb:masterfrom
skyelves:export-D96414538
Mar 20, 2026
Merged

feat: Add documentation for CREATE VECTOR INDEX (#27332)#27332
skyelves merged 1 commit intoprestodb:masterfrom
skyelves:export-D96414538

Conversation

@skyelves
Copy link
Copy Markdown
Member

@skyelves skyelves commented Mar 13, 2026

Summary:

Add documentation for CREATE VECTOR INDEX

Release Notes

== NO RELEASE NOTE ==

Reviewed By: zhichenxu-meta

Differential Revision: D96414538

@skyelves skyelves requested review from a team, elharo and steveburnett as code owners March 13, 2026 18:23
@sourcery-ai
Copy link
Copy Markdown
Contributor

sourcery-ai bot commented Mar 13, 2026

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Documents the new CREATE VECTOR INDEX SQL command by adding a dedicated reference page and wiring it into the main SQL documentation index.

File-Level Changes

Change Details Files
Add a dedicated SQL reference page for CREATE VECTOR INDEX.
  • Introduce a new Sphinx .rst page documenting the CREATE VECTOR INDEX statement syntax and semantics.
  • Describe required and optional clauses, parameters, and usage notes for CREATE VECTOR INDEX.
  • Include examples demonstrating how to create vector indexes in typical use cases.
presto-docs/src/main/sphinx/sql/create-vector-index.rst
Register the CREATE VECTOR INDEX documentation in the main SQL documentation index.
  • Update the primary SQL reference index to link to the CREATE VECTOR INDEX page so it appears in the rendered docs navigation.
  • Ensure the new page participates in the SQL command TOC and any relevant Sphinx toctree structures.
presto-docs/src/main/sphinx/sql.rst

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Copy Markdown
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Copy link
Copy Markdown
Contributor

@steveburnett steveburnett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the documentation! Just a nit of phrasing. Take a look at https://docs.gitlab.com/development/documentation/styleguide/word_list/#eg and change my suggestions to "such as" or another option if you like those better.

@github-actions github-actions bot added the docs label Mar 13, 2026
@github-project-automation github-project-automation bot moved this to 🆕 Unprioritized in Presto Documentation Mar 13, 2026
@github-project-automation github-project-automation bot moved this from 🆕 Unprioritized to 🏗 In progress in Presto Documentation Mar 13, 2026
@meta-codesync meta-codesync bot changed the title feat: Add documentation for CREATE VECTOR INDEX (#27331) feat: Add documentation for CREATE VECTOR INDEX (#27332) Mar 17, 2026
skyelves added a commit to skyelves/presto that referenced this pull request Mar 17, 2026
Summary:


Add documentation for CREATE VECTOR INDEX

Differential Revision: D96414538
@skyelves
Copy link
Copy Markdown
Member Author

Thank you for the documentation! Just a nit of phrasing. Take a look at https://docs.gitlab.com/development/documentation/styleguide/word_list/#eg and change my suggestions to "such as" or another option if you like those better.

Good point! I have changed them to for example

steveburnett
steveburnett previously approved these changes Mar 18, 2026
Copy link
Copy Markdown
Contributor

@steveburnett steveburnett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! (docs)

Pull updated branch, new local doc build, looks good. Thanks!

@github-project-automation github-project-automation bot moved this from 🏗 In progress to ✅ Done in Presto Documentation Mar 18, 2026
skyelves added a commit to skyelves/presto that referenced this pull request Mar 18, 2026
Summary:


Add documentation for CREATE VECTOR INDEX

Reviewed By: zhichenxu-meta

Differential Revision: D96414538
skyelves added a commit to skyelves/presto that referenced this pull request Mar 18, 2026
Summary:
Pull Request resolved: prestodb#27332

Pull Request resolved: prestodb#27331

Add documentation for CREATE VECTOR INDEX

Reviewed By: zhichenxu-meta

Differential Revision: D96414538
@linux-foundation-easycla
Copy link
Copy Markdown

linux-foundation-easycla bot commented Mar 18, 2026

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: skyelves / name: Ke Wang (9ce7c8b)

@github-actions github-actions bot removed the docs label Mar 18, 2026
skyelves added a commit to skyelves/presto that referenced this pull request Mar 20, 2026
Summary:


Add documentation for CREATE VECTOR INDEX

Reviewed By: zhichenxu-meta

Differential Revision: D96414538
@github-actions github-actions bot added the docs label Mar 20, 2026
skyelves added a commit to skyelves/presto that referenced this pull request Mar 20, 2026
Summary:


Add documentation for CREATE VECTOR INDEX

Reviewed By: zhichenxu-meta

Differential Revision: D96414538
Summary:
Pull Request resolved: prestodb#27332

Pull Request resolved: prestodb#27331

Add documentation for CREATE VECTOR INDEX

## Release Notes
```
== NO RELEASE NOTE ==
```

Reviewed By: zhichenxu-meta

Differential Revision: D96414538
@skyelves skyelves merged commit 84767cc into prestodb:master Mar 20, 2026
87 of 88 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

3 participants