Skip to content

docs(plugin-iceberg): Supplement documentation for transaction support#27318

Merged
hantangwangd merged 1 commit intoprestodb:masterfrom
hantangwangd:docs_supplement
Mar 12, 2026
Merged

docs(plugin-iceberg): Supplement documentation for transaction support#27318
hantangwangd merged 1 commit intoprestodb:masterfrom
hantangwangd:docs_supplement

Conversation

@hantangwangd
Copy link
Copy Markdown
Member

@hantangwangd hantangwangd commented Mar 12, 2026

Description

This PR supplements the documentation for Iceberg transaction support, adding descriptions for the following two features:

  • multi-table read, single-table write capability under snapshot isolation
  • read-your-writes visibility semantics in uncommitted transactions

Motivation and Context

Add more details about Iceberg transaction features

Impact

N/A

Test Plan

N/A

Contributor checklist

  • Please make sure your submission complies with our contributing guide, in particular code style and commit standards.
  • PR description addresses the issue accurately and concisely. If the change is non-trivial, a GitHub Issue is referenced.
  • Documented new properties (with its default value), SQL syntax, functions, or other functionality.
  • If release notes are required, they follow the release notes guidelines.
  • Adequate tests were added if applicable.
  • CI passed.
  • If adding new dependencies, verified they have an OpenSSF Scorecard score of 5.0 or higher (or obtained explicit TSC approval for lower scores).

Release Notes

== NO RELEASE NOTE ==

Summary by Sourcery

Update Iceberg connector documentation to describe additional transaction semantics and capabilities.

Documentation:

  • Document snapshot isolation support for multi-table reads with single-table writes in Iceberg transactions.
  • Describe read-your-writes visibility semantics for uncommitted Iceberg transactions.

@sourcery-ai
Copy link
Copy Markdown
Contributor

sourcery-ai bot commented Mar 12, 2026

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Updates the Iceberg connector documentation to describe transaction semantics, specifically multi-table read/single-table write behavior under snapshot isolation and read-your-writes visibility for uncommitted transactions.

File-Level Changes

Change Details Files
Document Iceberg transaction semantics and capabilities.
  • Expand the Iceberg connector docs to describe supported multi-table read and single-table write patterns under snapshot isolation.
  • Clarify read-your-writes visibility guarantees within a single uncommitted transaction.
  • Integrate the new transactional behavior descriptions into the existing transactions/consistency section for the Iceberg connector.
presto-docs/src/main/sphinx/connector/iceberg.rst

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Copy Markdown
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@github-actions github-actions bot added the docs label Mar 12, 2026
@github-project-automation github-project-automation bot moved this to 🆕 Unprioritized in Presto Documentation Mar 12, 2026
@hantangwangd hantangwangd changed the title docs(plugin-iceberg) Supplement documentation for transaction support docs(plugin-iceberg): Supplement documentation for transaction support Mar 12, 2026
Copy link
Copy Markdown
Contributor

@steveburnett steveburnett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! (docs)

Pull branch, local doc build, looks good. Thanks!

@github-project-automation github-project-automation bot moved this from 🆕 Unprioritized to ✅ Done in Presto Documentation Mar 12, 2026
@hantangwangd hantangwangd merged commit 7925aff into prestodb:master Mar 12, 2026
133 of 141 checks passed
@hantangwangd hantangwangd deleted the docs_supplement branch March 12, 2026 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

2 participants