-
Notifications
You must be signed in to change notification settings - Fork 5.5k
feat: Add syntax support for CREATE VECTOR INDEX (#27307) #27307
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
146 changes: 146 additions & 0 deletions
146
presto-parser/src/main/java/com/facebook/presto/sql/tree/CreateVectorIndex.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,146 @@ | ||
| /* | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
| package com.facebook.presto.sql.tree; | ||
|
|
||
| import com.google.common.collect.ImmutableList; | ||
|
|
||
| import java.util.List; | ||
| import java.util.Objects; | ||
| import java.util.Optional; | ||
|
|
||
| import static com.google.common.base.MoreObjects.toStringHelper; | ||
| import static java.util.Objects.requireNonNull; | ||
|
|
||
| public class CreateVectorIndex | ||
| extends Statement | ||
| { | ||
| private final QualifiedName indexName; | ||
| private final QualifiedName tableName; | ||
| private final List<Identifier> columns; | ||
| private final Optional<Expression> updatingFor; | ||
| private final List<Property> properties; | ||
|
|
||
| public CreateVectorIndex( | ||
| QualifiedName indexName, | ||
| QualifiedName tableName, | ||
| List<Identifier> columns, | ||
| Optional<Expression> updatingFor, | ||
| List<Property> properties) | ||
| { | ||
| this(Optional.empty(), indexName, tableName, columns, updatingFor, properties); | ||
| } | ||
|
|
||
| public CreateVectorIndex( | ||
| NodeLocation location, | ||
| QualifiedName indexName, | ||
| QualifiedName tableName, | ||
| List<Identifier> columns, | ||
| Optional<Expression> updatingFor, | ||
| List<Property> properties) | ||
| { | ||
| this(Optional.of(location), indexName, tableName, columns, updatingFor, properties); | ||
| } | ||
|
|
||
| private CreateVectorIndex( | ||
| Optional<NodeLocation> location, | ||
| QualifiedName indexName, | ||
| QualifiedName tableName, | ||
| List<Identifier> columns, | ||
| Optional<Expression> updatingFor, | ||
| List<Property> properties) | ||
| { | ||
| super(location); | ||
| this.indexName = requireNonNull(indexName, "indexName is null"); | ||
| this.tableName = requireNonNull(tableName, "tableName is null"); | ||
| this.columns = ImmutableList.copyOf(requireNonNull(columns, "columns is null")); | ||
| this.updatingFor = requireNonNull(updatingFor, "updatingFor is null"); | ||
| this.properties = ImmutableList.copyOf(requireNonNull(properties, "properties is null")); | ||
| } | ||
|
|
||
| public QualifiedName getIndexName() | ||
| { | ||
| return indexName; | ||
| } | ||
|
|
||
| public QualifiedName getTableName() | ||
| { | ||
| return tableName; | ||
| } | ||
|
|
||
| public List<Identifier> getColumns() | ||
| { | ||
| return columns; | ||
| } | ||
|
|
||
| public Optional<Expression> getUpdatingFor() | ||
| { | ||
| return updatingFor; | ||
| } | ||
|
|
||
| public List<Property> getProperties() | ||
| { | ||
| return properties; | ||
| } | ||
|
|
||
| @Override | ||
| public <R, C> R accept(AstVisitor<R, C> visitor, C context) | ||
| { | ||
| return visitor.visitCreateVectorIndex(this, context); | ||
| } | ||
|
|
||
| @Override | ||
| public List<Node> getChildren() | ||
| { | ||
| ImmutableList.Builder<Node> children = ImmutableList.builder(); | ||
| children.addAll(columns); | ||
| updatingFor.ifPresent(children::add); | ||
| children.addAll(properties); | ||
| return children.build(); | ||
| } | ||
|
|
||
| @Override | ||
| public int hashCode() | ||
| { | ||
| return Objects.hash(indexName, tableName, columns, updatingFor, properties); | ||
| } | ||
|
|
||
| @Override | ||
| public boolean equals(Object obj) | ||
| { | ||
| if (this == obj) { | ||
| return true; | ||
| } | ||
| if ((obj == null) || (getClass() != obj.getClass())) { | ||
| return false; | ||
| } | ||
| CreateVectorIndex o = (CreateVectorIndex) obj; | ||
| return Objects.equals(indexName, o.indexName) && | ||
| Objects.equals(tableName, o.tableName) && | ||
| Objects.equals(columns, o.columns) && | ||
| Objects.equals(updatingFor, o.updatingFor) && | ||
| Objects.equals(properties, o.properties); | ||
| } | ||
|
|
||
| @Override | ||
| public String toString() | ||
| { | ||
| return toStringHelper(this) | ||
| .add("indexName", indexName) | ||
| .add("tableName", tableName) | ||
| .add("columns", columns) | ||
| .add("updatingFor", updatingFor) | ||
| .add("properties", properties) | ||
| .toString(); | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The RFC defines ON TABLE candidates_table(id, embedding) with two required columns. Should the parser enforce exactly 2 columns? If
single-column is valid (using $row_id for id), this should be documented.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for comments! After discussing several rounds, we decide to proceed with keeping $row_id optional. We will update RFC accordingly.
We want to support either (embedding) or (embedding, row_id)