docs: Fix formatting in router/scheduler.rst#27303
Merged
steveburnett merged 1 commit intoprestodb:masterfrom Mar 11, 2026
Merged
docs: Fix formatting in router/scheduler.rst#27303steveburnett merged 1 commit intoprestodb:masterfrom
steveburnett merged 1 commit intoprestodb:masterfrom
Conversation
Contributor
Reviewer's guide (collapsed on small PRs)Reviewer's GuideAdjusts the documentation formatting and wording in router/scheduler.rst so that algorithm descriptions are visually nested under their list items and clarifies some explanatory text. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Contributor
There was a problem hiding this comment.
Hey - I've found 1 issue
Prompt for AI Agents
Please address the comments from this code review:
## Individual Comments
### Comment 1
<location path="presto-docs/src/main/sphinx/router/scheduler.rst" line_range="25" />
<code_context>
* ``USER_HASH``
-Selecting a clusters by hashing the username. This ensures queries from the same
-user will always be routed to the same cluster.
+ Selecting a clusters by hashing the username. This ensures queries from the same
</code_context>
<issue_to_address>
**issue (typo):** Fix grammatical error in "Selecting a clusters" phrase.
Please update the phrase to either "Selecting a cluster by hashing the username" or "Selecting clusters by hashing the username" to fix the grammar.
```suggestion
Selecting a cluster by hashing the username. This ensures queries from the same
```
</issue_to_address>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
51d2c56 to
935fe5d
Compare
pramodsatya
approved these changes
Mar 10, 2026
Contributor
pramodsatya
left a comment
There was a problem hiding this comment.
Thanks for the fix @steveburnett.
hantangwangd
approved these changes
Mar 11, 2026
Member
hantangwangd
left a comment
There was a problem hiding this comment.
Thanks @steveburnett, lgtm!
This was referenced Mar 31, 2026
15 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The formatting in router/scheduler.rst could be improved to make more sense visually.
Because the algorithms are listed as unordered list items they are indented, but the text about that algorithm is unindented and flush left. See screenshot.

This PR indents the text about each list item to fall within it to improve readability. A couple of small text edits have also been made for clarity.
Motivation and Context
Improves readability.
Impact
Documentation.
Test Plan
Local doc builds.
For the "before" state, see the screenshot above.
After:

Contributor checklist
Release Notes
Summary by Sourcery
Documentation: