Skip to content

fix(native): Caps the count metric at int64_t's max value #27295

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aditi-pandit merged 1 commit into from
Mar 31, 2026
+7 −1
Merged

fix(native): Caps the count metric at int64_t's max value #27295

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion presto-native-execution/presto_cpp/main/PrestoTask.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -998,11 +998,17 @@ folly::dynamic PrestoTask::toJson() const {
protocol::RuntimeMetric toRuntimeMetric(
const std::string& name,
const RuntimeMetric& metric) {
// Presto's RuntimeMetric uses int64_t for count, but Velox's RuntimeMetric
// uses uint64_t. To avoid overflow, we cap the count at int64_t's max value.
static const uint64_t maxCount =
static_cast<uint64_t>(std::numeric_limits<int64_t>::max());
const auto count = static_cast<int64_t>(
std::min(static_cast<uint64_t>(metric.count), maxCount));
return protocol::RuntimeMetric{
name,
toPrestoRuntimeUnit(metric.unit),
metric.sum,
metric.count,
count,
metric.max,
metric.min};
}
Expand Down
Loading