feat(native): Split IndexLookupJoin stats for IndexSource#27292
Merged
zacw7 merged 1 commit intoprestodb:masterfrom Mar 10, 2026
Merged
feat(native): Split IndexLookupJoin stats for IndexSource#27292zacw7 merged 1 commit intoprestodb:masterfrom
zacw7 merged 1 commit intoprestodb:masterfrom
Conversation
Contributor
Reviewer's GuideAdds an expansion step for operator stats so that IndexLookupJoin, which embeds IndexSource, reports separate stats entries corresponding to Presto’s logical plan nodes. Class diagram for OperatorStats and expandOperatorStatsclassDiagram
class OperatorStats {
+string operatorType
+optional StatsSplitter statsSplitter
}
class StatsSplitter {
+vector~OperatorStats~ operator() (OperatorStats opStats)
}
class PrestoTaskHelpers {
+vector~OperatorStats~ expandOperatorStats(vector~OperatorStats~ operatorStats)
}
OperatorStats --> StatsSplitter : uses
PrestoTaskHelpers ..> OperatorStats : processes
PrestoTaskHelpers ..> StatsSplitter : invokes when
note for PrestoTaskHelpers "expandOperatorStats expands IndexLookupJoin stats into multiple OperatorStats entries, including a separate one for IndexSource"
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Contributor
|
Are there followups for this PR? Maybe some comments on this one:
|
9a64aa5 to
540eb67
Compare
IndexLookupJoin embeds IndexSource as a single Velox operator, but Presto's plan has them as two separate logical plan nodes. This change expands IndexLookupJoin's operator stats using its StatsSplitter so that the Presto coordinator sees stats for both plan nodes.
tanjialiang
approved these changes
Mar 10, 2026
This was referenced Mar 31, 2026
15 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
IndexLookupJoin embeds IndexSource as a single Velox operator, but Presto's plan has them as two separate logical plan nodes. This change expands IndexLookupJoin's operator stats using its StatsSplitter so that the Presto coordinator sees stats for both plan nodes.
Summary by Sourcery
Enhancements: