Skip to content

chore(ci): Advance velox#27271

Merged
amitkdutta merged 1 commit intoprestodb:masterfrom
amitkdutta:velioo
Mar 6, 2026
Merged

chore(ci): Advance velox#27271
amitkdutta merged 1 commit intoprestodb:masterfrom
amitkdutta:velioo

Conversation

@amitkdutta
Copy link
Copy Markdown
Contributor

@amitkdutta amitkdutta commented Mar 5, 2026

== NO RELEASE NOTE ==

Summary by Sourcery

Enhancements:

  • Simplify Hive and Iceberg connector table handle construction by dropping the deprecated pushdown filter enabled parameter from utility and connector functions.

@amitkdutta amitkdutta requested review from a team as code owners March 5, 2026 19:39
@prestodb-ci prestodb-ci added the from:Meta PR from Meta label Mar 5, 2026
@sourcery-ai
Copy link
Copy Markdown
Contributor

sourcery-ai bot commented Mar 5, 2026

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Updates the Velox dependency pointer and aligns Presto native connector utilities with a changed Velox HiveTableHandle API by removing the pushdown-filter flag parameter and its propagation through Hive and Iceberg table-handle conversion paths.

Class diagram for updated Presto-to-Velox table-handle conversions

classDiagram
    class IcebergPrestoToVeloxConnector {
        +toVeloxTableHandle(domainPredicate, remainingPredicate, tableName, dataColumns, tableHandle, icebergLayout, hivePartitionKeys) std::unique_ptr~velox::connector::ConnectorTableHandle~
    }

    class HivePrestoToVeloxConnector {
        +toVeloxTableHandle(domainPredicate, remainingPredicate, tableName, dataColumns, tableHandle, hiveLayout, hivePartitionKeys) std::unique_ptr~velox::connector::ConnectorTableHandle~
    }

    class IcebergConnectorUtils {
        +toIcebergTableHandle(domainPredicate, remainingPredicate, tableName, dataColumns, tableHandle, hivePartitionKeys, bucketNumber, tableParameters, columnHandles, queryId, connectorId) std::unique_ptr~velox::connector::ConnectorTableHandle~
    }

    class PrestoToVeloxConnectorUtils {
        +toHiveTableHandle(domainPredicate, remainingPredicate, tableName, dataColumns, tableHandle, hivePartitionKeys, bucketNumber, tableParameters, columnHandles, queryId, connectorId) std::unique_ptr~velox::connector::ConnectorTableHandle~
    }

    class velox_connector_hive_HiveTableHandle {
        +HiveTableHandle(connectorId, tableName, subfieldFilters, remainingFilter, dataColumns, partitionKey, bucketNumber, tableParameters, connectorId2)
    }

    IcebergPrestoToVeloxConnector --> IcebergConnectorUtils : calls toIcebergTableHandle
    HivePrestoToVeloxConnector --> PrestoToVeloxConnectorUtils : calls toHiveTableHandle
    IcebergConnectorUtils --> velox_connector_hive_HiveTableHandle : constructs
    PrestoToVeloxConnectorUtils --> velox_connector_hive_HiveTableHandle : constructs

    %% Note: The removed isPushdownFilterEnabled parameter is no longer present
    %% in toIcebergTableHandle, toHiveTableHandle, and HiveTableHandle constructor.
Loading

File-Level Changes

Change Details Files
Align connector table-handle construction with updated Velox HiveTableHandle signature that no longer takes a pushdown-filter flag.
  • Remove the isPushdownFilterEnabled parameter from toIcebergTableHandle and stop passing it when constructing HiveTableHandle instances.
  • Stop threading pushdownFilterEnabled from IcebergPrestoToVeloxConnector::toVeloxTableHandle into the Iceberg table-handle conversion helper.
  • Remove the isPushdownFilterEnabled parameter from toHiveTableHandle and its use when creating HiveTableHandle objects.
  • Stop threading pushdownFilterEnabled from HivePrestoToVeloxConnector::toVeloxTableHandle into the Hive table-handle conversion helper.
  • Update the declaration of toHiveTableHandle in the connector utils header to match the new implementation signature.
presto-native-execution/presto_cpp/main/connectors/IcebergPrestoToVeloxConnector.cpp
presto-native-execution/presto_cpp/main/connectors/PrestoToVeloxConnectorUtils.cpp
presto-native-execution/presto_cpp/main/connectors/HivePrestoToVeloxConnector.cpp
presto-native-execution/presto_cpp/main/connectors/PrestoToVeloxConnectorUtils.h
Advance the Velox dependency pointer used by native execution.
  • Update the velox dependency reference (likely a git submodule or pointer file) under the native execution directory to a newer Velox revision.
presto-native-execution/velox

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Copy Markdown
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@amitkdutta amitkdutta changed the title [native] Advance velox chore(native): Advance velox Mar 5, 2026
@amitkdutta amitkdutta changed the title chore(native): Advance velox chore(ci): Advance velox Mar 5, 2026
@amitkdutta amitkdutta marked this pull request as draft March 6, 2026 00:51
@amitkdutta amitkdutta marked this pull request as ready for review March 6, 2026 04:56
Copy link
Copy Markdown
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@amitkdutta amitkdutta merged commit f751174 into prestodb:master Mar 6, 2026
84 checks passed
garimauttam pushed a commit to garimauttam/presto that referenced this pull request Mar 9, 2026
```
== NO RELEASE NOTE ==
```

## Summary by Sourcery

Enhancements:
- Simplify Hive and Iceberg connector table handle construction by
dropping the deprecated pushdown filter enabled parameter from utility
and connector functions.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

from:Meta PR from Meta

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants