Merged
Conversation
Contributor
Reviewer's guide (collapsed on small PRs)Reviewer's GuideUpdates the Velox dependency pointer and aligns Presto native connector utilities with a changed Velox HiveTableHandle API by removing the pushdown-filter flag parameter and its propagation through Hive and Iceberg table-handle conversion paths. Class diagram for updated Presto-to-Velox table-handle conversionsclassDiagram
class IcebergPrestoToVeloxConnector {
+toVeloxTableHandle(domainPredicate, remainingPredicate, tableName, dataColumns, tableHandle, icebergLayout, hivePartitionKeys) std::unique_ptr~velox::connector::ConnectorTableHandle~
}
class HivePrestoToVeloxConnector {
+toVeloxTableHandle(domainPredicate, remainingPredicate, tableName, dataColumns, tableHandle, hiveLayout, hivePartitionKeys) std::unique_ptr~velox::connector::ConnectorTableHandle~
}
class IcebergConnectorUtils {
+toIcebergTableHandle(domainPredicate, remainingPredicate, tableName, dataColumns, tableHandle, hivePartitionKeys, bucketNumber, tableParameters, columnHandles, queryId, connectorId) std::unique_ptr~velox::connector::ConnectorTableHandle~
}
class PrestoToVeloxConnectorUtils {
+toHiveTableHandle(domainPredicate, remainingPredicate, tableName, dataColumns, tableHandle, hivePartitionKeys, bucketNumber, tableParameters, columnHandles, queryId, connectorId) std::unique_ptr~velox::connector::ConnectorTableHandle~
}
class velox_connector_hive_HiveTableHandle {
+HiveTableHandle(connectorId, tableName, subfieldFilters, remainingFilter, dataColumns, partitionKey, bucketNumber, tableParameters, connectorId2)
}
IcebergPrestoToVeloxConnector --> IcebergConnectorUtils : calls toIcebergTableHandle
HivePrestoToVeloxConnector --> PrestoToVeloxConnectorUtils : calls toHiveTableHandle
IcebergConnectorUtils --> velox_connector_hive_HiveTableHandle : constructs
PrestoToVeloxConnectorUtils --> velox_connector_hive_HiveTableHandle : constructs
%% Note: The removed isPushdownFilterEnabled parameter is no longer present
%% in toIcebergTableHandle, toHiveTableHandle, and HiveTableHandle constructor.
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
gggrace14
approved these changes
Mar 6, 2026
garimauttam
pushed a commit
to garimauttam/presto
that referenced
this pull request
Mar 9, 2026
``` == NO RELEASE NOTE == ``` ## Summary by Sourcery Enhancements: - Simplify Hive and Iceberg connector table handle construction by dropping the deprecated pushdown filter enabled parameter from utility and connector functions.
This was referenced Mar 31, 2026
15 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by Sourcery
Enhancements: