Conversation
Contributor
Reviewer's guide (collapsed on small PRs)Reviewer's GuideAdds a configurable feature flag for pushing partial aggregations through joins and wires it into both FeaturesConfig and SystemSessionProperties, with corresponding defaults and property-mapping tests. Class diagram for new PushPartialAggregationThroughJoin feature configclassDiagram
class FeaturesConfig {
- boolean pushAggregationThroughJoin
- boolean pushPartialAggregationThroughJoin
+ boolean isPushAggregationThroughJoin()
+ FeaturesConfig setPushAggregationThroughJoin(boolean value)
+ boolean isPushPartialAggregationThroughJoin()
+ FeaturesConfig setPushPartialAggregationThroughJoin(boolean pushPartialAggregationThroughJoin)
}
class SystemSessionProperties {
+ SystemSessionProperties(FeaturesConfig featuresConfig)
+ void booleanProperty(String name, String description, boolean defaultValue, boolean hidden)
}
FeaturesConfig <.. SystemSessionProperties : uses
Flow diagram for resolving push partial aggregation through join configflowchart LR
A[Config file or default values] --> B[FeaturesConfig.setPushPartialAggregationThroughJoin]
B --> C[FeaturesConfig.pushPartialAggregationThroughJoin]
C --> D[SystemSessionProperties constructor]
D --> E[booleanProperty for PUSH_PARTIAL_AGGREGATION_THROUGH_JOIN]
E --> F[Session property default for push partial aggregation through join]
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
Contributor
|
Please add documentation for the new configuration property. |
tdcmeehan
approved these changes
Mar 9, 2026
steveburnett
approved these changes
Mar 9, 2026
Contributor
steveburnett
left a comment
There was a problem hiding this comment.
LGTM! (docs)
Pull branch, local doc build, looks good. Thanks!
This was referenced Mar 31, 2026
15 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description, Motivation and Context
Adds a feature config for PushPartialAggregationThroughJoin; only a session property exists for it at the moment
Test Plan
CI
Contributor checklist
Release Notes
Please follow release notes guidelines and fill in the release notes below.