Skip to content

fix: Fix update error with pushdownsubfields optimization #27254

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zation99 merged 1 commit into from
Mar 5, 2026
Merged

fix: Fix update error with pushdownsubfields optimization #27254

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 23 additions & 0 deletions ...to-iceberg/src/test/java/com/facebook/presto/iceberg/IcebergDistributedSmokeTestBase.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2544,4 +2544,27 @@ public void testIOExplainWithTimestampWithTimeZone()
assertUpdate("DROP TABLE test_tstz_io");
}
}

@Test
public void testPushdownSubfieldsWithDml()
{
QueryRunner queryRunner = getQueryRunner();
Session session = Session.builder(getSession())
.setSystemProperty("pushdown_subfields_enabled", "true")
.build();
try {
queryRunner.execute("CREATE TABLE test_pushdown_subfields_dml(a INTEGER, b VARCHAR, c VARCHAR)");
queryRunner.execute("INSERT INTO test_pushdown_subfields_dml VALUES (1, 'x', 'p'), (2, 'y', 'q'), (3, 'z', 'r')");

assertUpdate(session, "UPDATE test_pushdown_subfields_dml SET a = 10 WHERE c = 'q'", 1);
assertQuery("SELECT a, b, c FROM test_pushdown_subfields_dml WHERE c = 'q'", "VALUES (10, 'y', 'q')");

assertUpdate(session, "UPDATE test_pushdown_subfields_dml SET a = 20 WHERE c = 'nonexistent'", 0);
assertUpdate("DELETE FROM test_pushdown_subfields_dml WHERE c = 'r'", 1);
assertQuery("SELECT a, b, c FROM test_pushdown_subfields_dml ORDER BY a", "VALUES (1, 'x', 'p'), (10, 'y', 'q')");
}
finally {
queryRunner.execute("DROP TABLE IF EXISTS test_pushdown_subfields_dml");
}
}
}
8 changes: 8 additions & 0 deletions ...n-base/src/main/java/com/facebook/presto/sql/planner/optimizations/PushdownSubfields.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,6 +75,7 @@
import com.facebook.presto.sql.planner.plan.GroupIdNode;
import com.facebook.presto.sql.planner.plan.RowNumberNode;
import com.facebook.presto.sql.planner.plan.SimplePlanRewriter;
import com.facebook.presto.sql.planner.plan.UpdateNode;
import com.facebook.presto.sql.relational.FunctionResolution;
import com.facebook.presto.sql.tree.QualifiedName;
import com.google.common.collect.ImmutableList;
Expand Down Expand Up @@ -494,6 +495,13 @@ public PlanNode visitDelete(DeleteNode node, RewriteContext<Context> context)
return context.defaultRewrite(node, context.get());
}

@Override
public PlanNode visitUpdate(UpdateNode node, RewriteContext<Context> context)
{
context.get().variables.addAll(node.getSource().getOutputVariables());
return context.defaultRewrite(node, context.get());
}

@Override
public PlanNode visitTopN(TopNNode node, RewriteContext<Context> context)
{
Expand Down
Loading