docs: Add documentation for Iceberg transaction support#27252
docs: Add documentation for Iceberg transaction support#27252hantangwangd merged 2 commits intoprestodb:masterfrom
Conversation
|
🧙 Sourcery has finished reviewing your pull request! Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
steveburnett
left a comment
There was a problem hiding this comment.
Thank you for the documentation! Just one nit of phrasing.
hantangwangd
left a comment
There was a problem hiding this comment.
Thank you so much for this documentation. I have one suggestion for addition, otherwise looks good to me.
9e7ac35 to
aba610d
Compare
steveburnett
left a comment
There was a problem hiding this comment.
LGTM! (docs)
Pull updated branch, new local doc build, looks good. Thanks!
hantangwangd
left a comment
There was a problem hiding this comment.
Thanks @garimauttam, lgtm!
|
One CI check You may need to rebase or push the branch to re-start this stuck CI check. If you do, re-request a review and I'll approve it then. |
c4f17eb
|
Hi @garimauttam, the CI stuck for docs-only PR has been fixed. Could you please rebase to the latest master branch? Then we can move forward and merge this PR. |
c4f17eb to
453647b
Compare
|
Hi @garimauttam I saw that my change and other people's changes became your commits or were authored by you, which causes the merge conflict. I guess you merged the changes from upstream into your working branch. Rebasing is the way I suggest syncing up the upstream. If you can reset your branch to your second doc commit, rebase upstream, and force push your branch, it should be able to solve the conflict. |
steveburnett
left a comment
There was a problem hiding this comment.
LGTM! (docs)
Note: The documentation is fine. Please re-request my review after you follow @yhwang's advice and I will be happy to approve it then.
453647b to
6993507
Compare
hantangwangd
left a comment
There was a problem hiding this comment.
Thanks @garimauttam, lgtm!
5f02e84 to
7fe4f81
Compare
steveburnett
left a comment
There was a problem hiding this comment.
LGTM! (docs)
Pull updated branch, new local doc build, looks good. Thanks!
Summary
Test plan
Fixes #27243
== NO RELEASE NOTE ==Summary by Sourcery
Documentation: