Skip to content

docs: Add documentation for Iceberg transaction support#27252

Merged
hantangwangd merged 2 commits intoprestodb:masterfrom
garimauttam:fix/iceberg-transaction-docs-27243
Mar 10, 2026
Merged

docs: Add documentation for Iceberg transaction support#27252
hantangwangd merged 2 commits intoprestodb:masterfrom
garimauttam:fix/iceberg-transaction-docs-27243

Conversation

@garimauttam
Copy link
Copy Markdown
Contributor

@garimauttam garimauttam commented Mar 3, 2026

Summary

  • add a new Transaction support section to Iceberg connector docs
  • document supported multi-statement write transactions on a single table
  • document current limitations and autocommit-only operations

Test plan

  • docs-only change; reviewed content against Iceberg transaction behavior in code/tests

Fixes #27243

== NO RELEASE NOTE ==

Summary by Sourcery

Documentation:

  • Add a Transaction support section to the Iceberg connector documentation covering multi-statement write transactions and autocommit-only operations.

@sourcery-ai
Copy link
Copy Markdown
Contributor

sourcery-ai bot commented Mar 3, 2026

🧙 Sourcery has finished reviewing your pull request!


Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Copy Markdown
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Copy link
Copy Markdown
Contributor

@steveburnett steveburnett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the documentation! Just one nit of phrasing.

@github-project-automation github-project-automation bot moved this from 🆕 Unprioritized to 🏗 In progress in Presto Documentation Mar 3, 2026
Copy link
Copy Markdown
Member

@hantangwangd hantangwangd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for this documentation. I have one suggestion for addition, otherwise looks good to me.

@garimauttam garimauttam force-pushed the fix/iceberg-transaction-docs-27243 branch from 9e7ac35 to aba610d Compare March 3, 2026 17:13
steveburnett
steveburnett previously approved these changes Mar 3, 2026
Copy link
Copy Markdown
Contributor

@steveburnett steveburnett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! (docs)

Pull updated branch, new local doc build, looks good. Thanks!

@github-project-automation github-project-automation bot moved this from 🏗 In progress to ✅ Done in Presto Documentation Mar 3, 2026
hantangwangd
hantangwangd previously approved these changes Mar 4, 2026
Copy link
Copy Markdown
Member

@hantangwangd hantangwangd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @garimauttam, lgtm!

@steveburnett
Copy link
Copy Markdown
Contributor

One CI check
arrowflight-java-tests (17, :presto-base-arrow-flight)
appears stuck since at least yesterday in pending status, "Expected - waiting for status to be reported".

You may need to rebase or push the branch to re-start this stuck CI check. If you do, re-request a review and I'll approve it then.

@hantangwangd
Copy link
Copy Markdown
Member

Hi @garimauttam, the CI stuck for docs-only PR has been fixed. Could you please rebase to the latest master branch? Then we can move forward and merge this PR.

@garimauttam garimauttam force-pushed the fix/iceberg-transaction-docs-27243 branch from c4f17eb to 453647b Compare March 9, 2026 14:02
@garimauttam garimauttam requested a review from yhwang as a code owner March 9, 2026 14:02
@yhwang
Copy link
Copy Markdown
Member

yhwang commented Mar 9, 2026

Hi @garimauttam I saw that my change and other people's changes became your commits or were authored by you, which causes the merge conflict. I guess you merged the changes from upstream into your working branch. Rebasing is the way I suggest syncing up the upstream. If you can reset your branch to your second doc commit, rebase upstream, and force push your branch, it should be able to solve the conflict.

steveburnett
steveburnett previously approved these changes Mar 9, 2026
Copy link
Copy Markdown
Contributor

@steveburnett steveburnett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! (docs)

Note: The documentation is fine. Please re-request my review after you follow @yhwang's advice and I will be happy to approve it then.

@garimauttam garimauttam closed this Mar 9, 2026
@garimauttam garimauttam force-pushed the fix/iceberg-transaction-docs-27243 branch from 453647b to 6993507 Compare March 9, 2026 22:23
@garimauttam garimauttam reopened this Mar 9, 2026
@github-project-automation github-project-automation bot moved this from ✅ Done to 🆕 Unprioritized in Presto Documentation Mar 9, 2026
@github-actions github-actions bot added the docs label Mar 10, 2026
hantangwangd
hantangwangd previously approved these changes Mar 10, 2026
Copy link
Copy Markdown
Member

@hantangwangd hantangwangd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @garimauttam, lgtm!

@github-project-automation github-project-automation bot moved this from 🆕 Unprioritized to ✅ Done in Presto Documentation Mar 10, 2026
Copy link
Copy Markdown
Contributor

@steveburnett steveburnett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! (docs)

Pull updated branch, new local doc build, looks good. Thanks!

@hantangwangd hantangwangd merged commit d6a34bc into prestodb:master Mar 10, 2026
86 checks passed
@garimauttam garimauttam deleted the fix/iceberg-transaction-docs-27243 branch March 10, 2026 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

Add documentation for Iceberg transaction support

4 participants