misc: Migrate cpp.ref_type and drift.recursive_reference in presto thrift

[iahs]

Summary:
Migrate cpp.ref_type and drift.recursive_reference unstructured annotations
to their structured equivalents in presto thrift files:

• presto_thrift.thrift
• temp_presto_thrift.thrift

Reviewed By: Mizuchi

== NO RELEASE NOTE ==

Summary by Sourcery

Migrate presto thrift definitions to use structured annotations for ExecutionFailureInfo references.

Enhancements:

• Replace legacy cpp.ref_type and drift.recursive_reference annotations with structured cpp and thrift annotation usage in presto_thrift.thrift and temp_presto_thrift.thrift.
• Add cpp and thrift annotation include files to the presto thrift IDL files to support structured annotations.

[sourcery-ai]

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Migrates unstructured cpp.ref_type and drift.recursive_reference annotations on ExecutionFailureInfo.cause to their structured equivalents in both presto_thrift.thrift and temp_presto_thrift.thrift, adding the necessary annotation includes.

Class diagram for updated ExecutionFailureInfo.thrift struct

classDiagram
  direction TB

  class ExecutionFailureInfo_Unstructured {
    +string type
    +string message
    +optional ExecutionFailureInfo cause
    +list~ExecutionFailureInfo~ suppressed
    +list~string~ stack
    +ErrorLocation errorLocation
    <<annotations>>
    cause: cpp.ref_type = shared
    cause: drift.recursive_reference = true
  }

  class ExecutionFailureInfo_Structured {
    +string type
    +string message
    +optional ExecutionFailureInfo cause
    +list~ExecutionFailureInfo~ suppressed
    +list~string~ stack
    +ErrorLocation errorLocation
    <<annotations>>
    cause: @cpp.Ref(type = cpp.RefType.SharedMutable)
    cause: @thrift.DeprecatedUnvalidatedAnnotations(items = "drift.recursive_reference=true")
  }

  ExecutionFailureInfo_Unstructured <|-- ExecutionFailureInfo_Structured

Loading

File-Level Changes

Change	Details	Files
Switch ExecutionFailureInfo.cause reference and recursive annotations from legacy unstructured syntax to structured Thrift/cpp annotations.	Add cpp and thrift annotation include files to the Thrift IDL so structured annotations are available. Replace inline cpp.ref_type="shared" annotation with @cpp.Ref{type = cpp.RefType.SharedMutable} on ExecutionFailureInfo.cause. Preserve the previous drift.recursive_reference behavior by encoding it into @thrift.DeprecatedUnvalidatedAnnotations for ExecutionFailureInfo.cause field.	presto-native-execution/presto_cpp/main/thrift/presto_thrift.thrift presto-native-execution/presto_cpp/main/thrift/temp_presto_thrift.thrift

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: iahs / name: Shai Szulanski (aba0dfe)

[sourcery-ai]

Hey - I've reviewed your changes and they look great!

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[steveburnett]

When you have time, please sign the Presto CLA as mentioned in this comment.

[iahs]

CLA signed

[amitkdutta]

Thanks @iahs

[aditi-pandit]

Thanks.