Skip to content

fix(native): Replace unsafe atol() with folly::to<> in PrestoExchangeSource #27223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
amitkdutta merged 1 commit into from
Feb 27, 2026
+5 −4
Merged

fix(native): Replace unsafe atol() with folly::to<> in PrestoExchangeSource #27223

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions presto-native-execution/presto_cpp/main/PrestoExchangeSource.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@
#include "presto_cpp/main/PrestoExchangeSource.h"

#include <fmt/core.h>
#include <folly/Conv.h>
#include <folly/SocketAddress.h>
#include <re2/re2.h>
#include <sstream>
Expand Down Expand Up @@ -297,10 +298,10 @@ void PrestoExchangeSource::processDataResponse(
!headers->getIsChunked(),
"Chunked http transferring encoding is not supported.");
}
const auto contentLengthStr = headers->getHeaders().getSingleOrEmpty(
proxygen::HTTP_HEADER_CONTENT_LENGTH);
const uint64_t contentLength =
atol(headers->getHeaders()
.getSingleOrEmpty(proxygen::HTTP_HEADER_CONTENT_LENGTH)
.c_str());
contentLengthStr.empty() ? 0 : folly::to<uint64_t>(contentLengthStr);
VLOG(1) << "Fetched data for " << basePath_ << "/" << sequence_ << ": "
<< contentLength << " bytes";

Expand Down Expand Up @@ -331,7 +332,7 @@ void PrestoExchangeSource::processDataResponse(
// token so we shouldn't update 'sequence_' if it is empty. Otherwise,
// 'sequence_' gets reset and we can't fetch any data from the source with
// the rolled back 'sequence_'.
ackSequenceOpt = atol(nextTokenStr.c_str());
ackSequenceOpt = folly::to<int64_t>(nextTokenStr);
} else {
VELOX_CHECK_EQ(
contentLength, 0, "next token is not set in non-empty data response");
Expand Down
Loading