fix: Increase max-task-update-size for the test

[vandreykiv]

Description

com.facebook.presto.verifier.framework.TestDataVerification.testLargeTableSelectStarCompiles fails with java.lang.AssertionError: expected [SUCCEEDED] but found [FAILED] because com.facebook.presto.spi.PrestoException: TaskUpdate size of 16.73MB has exceeded the limit of 16MB
Default limit is 16Mb and with recent dependencies updates task update size started to cross it for test that generates many columns

Contributor checklist

• Please make sure your submission complies with our contributing
  guide,
  in particular code
  style
  and commit
  standards.
• PR description addresses the issue accurately and concisely. If
  the change is non-trivial, a GitHub Issue is referenced.
• Documented new properties (with its default value), SQL syntax,
  functions, or other functionality.
• If release notes are required, they follow the release notes
  guidelines.
• Adequate tests were added if applicable.
• CI passed.
• If adding new dependencies, verified they have an OpenSSF
  Scorecard score of 5.0 or
  higher (or obtained explicit TSC approval for lower scores).

Release Notes

Please follow release notes
guidelines
and fill in the release notes below.

== NO RELEASE NOTE ==

Differential Revision: D94558539

[sourcery-ai]

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Updates timezone data by bumping the Joda-Time dependency, synchronizes Presto’s internal zone index with the new tzdata, and adjusts the test StandaloneQueryRunner configuration to include a new internal communication limit for task updates.

Sequence diagram for task update flow with new internal communication limit

sequenceDiagram
    participant TestSuite
    participant StandaloneQueryRunner
    participant Coordinator
    participant InternalCommunication
    participant Worker

    TestSuite->>StandaloneQueryRunner: startCluster()
    StandaloneQueryRunner->>Coordinator: createServerWithConfig(taskUpdateLimit)
    Coordinator->>InternalCommunication: applyConfig(taskUpdateLimit)

    TestSuite->>StandaloneQueryRunner: executeQuery()
    StandaloneQueryRunner->>Coordinator: submitQuery()
    Coordinator->>Worker: createTasks()

    Worker->>Coordinator: sendTaskUpdate()
    Coordinator->>InternalCommunication: sendTaskUpdateRequest()
    InternalCommunication->>InternalCommunication: checkSizeAgainstTaskUpdateLimit()
    alt within limit
        InternalCommunication->>Coordinator: acceptTaskUpdate()
        Coordinator->>TestSuite: returnResults()
    else exceeds limit
        InternalCommunication->>Coordinator: rejectTaskUpdate()
        Coordinator->>TestSuite: failQuery(taskUpdateTooLarge)
    end

Loading

Flow diagram for updated timezone data resolution via Joda-Time and zone index

flowchart LR
    JodaTimeDependency["Joda-Time dependency (2.14.0)"] --> TZData["Embedded tzdata"]
    TZData --> ZoneIndexProperties["zone-index.properties (includes America/Coyhaique)"]
    ZoneIndexProperties --> PrestoTimeZoneRegistry["PrestoTimeZoneRegistry"]
    PrestoTimeZoneRegistry --> DateTimeFunctions["Date/time functions"]
    DateTimeFunctions --> QueryExecution["Query execution with time zones"]

Loading

File-Level Changes

Change	Details	Files
Update Joda-Time dependency to pick up newer timezone data.	Bump dep.joda.version Maven property from 2.13.1 to 2.14.0 so tests and runtime align with updated tzdata. Rely on the existing comment as a reminder that Joda tzdata must match deployed JVM tzdata when changing this version.	pom.xml
Align Presto zone index with updated tzdata.	Append a new zone mapping entry for America/Coyhaique with id 2234 to the zone-index.properties resource to reflect the new timezone data set.	presto-common/src/main/resources/com/facebook/presto/common/type/zone-index.properties
Adjust test server configuration to include internal communication task update size limit.	Extend the TestingPrestoServer properties builder to set experimental.internal-communication.max-task-update-size to 32MB for the StandaloneQueryRunner-based tests. Preserve existing test server properties such as timeouts, scheduler settings, and datasources while appending the new configuration key.	presto-tests/src/main/java/com/facebook/presto/tests/StandaloneQueryRunner.java

Possibly linked issues

• #(not provided): The PR updates tzdata and explicitly adds America/Coyhaique to zone-index.properties, directly fulfilling the issue.

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey - I've left some high level feedback:

• In StandaloneQueryRunner, consider either referencing a shared constant or adding a brief comment explaining why experimental.internal-communication.max-task-update-size is set to 32MB so future maintainers understand why the default is overridden in tests.

Prompt for AI Agents

Please address the comments from this code review:

## Overall Comments
- In `StandaloneQueryRunner`, consider either referencing a shared constant or adding a brief comment explaining why `experimental.internal-communication.max-task-update-size` is set to `32MB` so future maintainers understand why the default is overridden in tests.

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[feilong-liu]

Can you add more detail on what is the problem being fixed here?

[vandreykiv]

Can you add more detail on what is the problem being fixed here?

Updated description with more details