Skip to content

Dummy docker image tests#27191

Closed
unidevel wants to merge 1 commit intoprestodb:masterfrom
unidevel:image-test
Closed

Dummy docker image tests#27191
unidevel wants to merge 1 commit intoprestodb:masterfrom
unidevel:image-test

Conversation

@unidevel
Copy link
Copy Markdown
Contributor

@unidevel unidevel commented Feb 23, 2026

Just for docker image testing, will close after tested.

Related PR: prestodb/docker-images#61

Summary by Sourcery

Update Docker image references for product tests to use alternative registry images.

Build:

  • Change singlenode-ldap docker-compose services to use unix280 centos7-oj8-openldap images instead of prestodb equivalents.
  • Update default HADOOP_BASE_IMAGE to unix280/hdp3.1-hive in common compose configuration.
  • Switch standard java-8-base service image to unix280/centos7-oj8 in shared Docker configuration.

@prestodb-ci prestodb-ci added the from:IBM PR from IBM label Feb 23, 2026
@sourcery-ai
Copy link
Copy Markdown
Contributor

sourcery-ai bot commented Feb 23, 2026

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Updates docker-compose and common config to point product tests at alternative docker images under the unix280 namespace instead of the prestodb namespace, for both the CentOS/OpenJDK/OpenLDAP image and the Hadoop base image.

File-Level Changes

Change Details Files
Point singlenode-ldap product test services at a different CentOS+OpenJDK+OpenLDAP docker image namespace.
  • Change presto-master service image to use unix280/centos7-oj8-openldap with the existing DOCKER_IMAGES_VERSION tag.
  • Change application-runner service image to use unix280/centos7-oj8-openldap with the existing DOCKER_IMAGES_VERSION tag.
  • Change ldapserver service image to use unix280/centos7-oj8-openldap with the existing DOCKER_IMAGES_VERSION tag.
presto-product-tests/conf/docker/singlenode-ldap/docker-compose.yml
Switch the default Hadoop base image used by compose scripts to a unix280-hosted image.
  • Update HADOOP_BASE_IMAGE default from prestodb/hdp3.1-hive to unix280/hdp3.1-hive while preserving override behavior and other environment exports.
presto-product-tests/conf/docker/common/compose-commons.sh
Use an alternate java-8 base docker image namespace in common docker-compose configuration.
  • Update java-8-base service image from prestodb/centos7-oj8 to unix280/centos7-oj8, still parameterized by DOCKER_IMAGES_VERSION and constrained to linux/amd64 platform.
presto-product-tests/conf/docker/common/standard.yml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@unidevel unidevel closed this Feb 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

from:IBM PR from IBM

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants