Skip to content

fix(build): Add library required for Velox as of 44e10f4#27166

Merged
czentgr merged 1 commit intoprestodb:masterfrom
simoneves:simoneves/add_velox_key_encoder_lib
Feb 20, 2026
Merged

fix(build): Add library required for Velox as of 44e10f4#27166
czentgr merged 1 commit intoprestodb:masterfrom
simoneves:simoneves/add_velox_key_encoder_lib

Conversation

@simoneves
Copy link
Copy Markdown
Contributor

@simoneves simoneves commented Feb 18, 2026

Description

Added velox_key_encoder library to main presto_server link.

Motivation and Context

Resolves link failure with Velox as of 44e10f4 (2026/2/13)

HiveIndexReader.cpp:(.text+0x1b37): undefined reference to facebook::velox::serializer::IndexBounds::set(facebook::velox::serializer::IndexBound, facebook::velox::serializer::IndexBound)

Impact

None.

Test Plan

Local builds so far.

Contributor checklist

  • Please make sure your submission complies with our contributing guide, in particular code style and commit standards.
  • PR description addresses the issue accurately and concisely. If the change is non-trivial, a GitHub Issue is referenced.
  • Documented new properties (with its default value), SQL syntax, functions, or other functionality.
  • If release notes are required, they follow the release notes guidelines.
  • Adequate tests were added if applicable.
  • CI passed.
  • If adding new dependencies, verified they have an OpenSSF Scorecard score of 5.0 or higher (or obtained explicit TSC approval for lower scores).

Release Notes

Please follow release notes guidelines and fill in the release notes below.

== NO RELEASE NOTE ==

Summary by Sourcery

Build:

  • Add velox_key_encoder to the presto_cpp main target link libraries to satisfy new Velox linkage requirements.

@simoneves simoneves requested review from a team as code owners February 18, 2026 23:14
@sourcery-ai
Copy link
Copy Markdown
Contributor

sourcery-ai bot commented Feb 18, 2026

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Links the new Velox key encoder library into the main Presto native server binary to resolve a missing symbol error introduced by recent Velox changes.

File-Level Changes

Change Details Files
Link the velox_key_encoder library into the presto_cpp main server target to resolve undefined reference errors from Velox serializer/index bounds usage.
  • Add velox_key_encoder to the target_link_libraries list for the presto_cpp main executable so it is linked into the native Presto server binary
  • Ensure the new Velox dependency is grouped with related Velox libraries already linked (Hive connector, Iceberg split reader, partition function, serializer, type parser, S3 FS)
presto-native-execution/presto_cpp/main/CMakeLists.txt

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Copy Markdown
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've left some high level feedback:

  • Since this fixes a compatibility issue with a specific Velox revision, consider guarding the velox_key_encoder linkage with a CMake check on the Velox version or feature so older Velox versions don’t accidentally gain an unused/invalid dependency.
  • If velox_key_encoder is only required by a specific connector or component, you might want to link it just to that target rather than the top-level presto_cpp main target to keep link dependencies more localized.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- Since this fixes a compatibility issue with a specific Velox revision, consider guarding the `velox_key_encoder` linkage with a CMake check on the Velox version or feature so older Velox versions don’t accidentally gain an unused/invalid dependency.
- If `velox_key_encoder` is only required by a specific connector or component, you might want to link it just to that target rather than the top-level `presto_cpp` main target to keep link dependencies more localized.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@simoneves simoneves changed the title Add library required for Velox as of 44e10f4 (2026/2/13) fix(build): Add library required for Velox as of 44e10f4 2026-02-13 Feb 18, 2026
@simoneves simoneves changed the title fix(build): Add library required for Velox as of 44e10f4 2026-02-13 fix(build): Add library required for Velox as of 44e10f4 Feb 18, 2026
@czentgr
Copy link
Copy Markdown
Contributor

czentgr commented Feb 19, 2026

@simoneves I assume this is only seen when building with cudf? We don't see this being an issue in the regular CI. Or is this for future (aka next velox update which is soon to happen)?

@simoneves
Copy link
Copy Markdown
Contributor Author

@simoneves I assume this is only seen when building with cudf? We don't see this being an issue in the regular CI. Or is this for future (aka next velox update which is soon to happen)?

Sorry, I should have been more clear. This fixes the linker failure that will happen (with C++ also) when Presto updates over commit 44e10f4 (@xiaoxmeng's Velox PR #16360) from Feb 13, which is literally the next commit on from where Presto is currently pinned. Like I said, please feel free to suggest an alternative solution if this is too heavy-handed.

Copy link
Copy Markdown
Contributor

@czentgr czentgr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, we could also add this with the velox update but this is fine too.

@simoneves
Copy link
Copy Markdown
Contributor Author

@czentgr I figured they would just be landed together

Copy link
Copy Markdown
Member

@hantangwangd hantangwangd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @simoneves

@czentgr czentgr merged commit c715313 into prestodb:master Feb 20, 2026
86 of 91 checks passed
@pramodsatya
Copy link
Copy Markdown
Contributor

Thanks for the fix @simoneves.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants