Skip to content

build(native): Add c-ares installation to Mac setup #27135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nmahadevuni merged 1 commit into from
Feb 17, 2026
Merged

build(native): Add c-ares installation to Mac setup #27135

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions presto-native-execution/scripts/setup-macos.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,16 @@ BUILD_DUCKDB="${BUILD_DUCKDB:-false}"
source "$(dirname "${BASH_SOURCE[0]}")/../velox/scripts/setup-macos.sh"
GPERF_VERSION="3.1"
DATASKETCHES_VERSION="5.2.0"
# c-ares is required for proxygen
MACOS_PRESTO_DEPS="c-ares"
Copy link
Copy Markdown
Contributor

@czentgr czentgr Feb 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's add a small comment somewhere that identifies where this is used (in this case by proxygen). So we keep track of it.


function install_presto_deps_from_brew {
local pkg

for pkg in ${MACOS_PRESTO_DEPS}; do
install_from_brew "${pkg}"
done
}
Comment thread
sourcery-ai[bot] marked this conversation as resolved.

function install_proxygen {
wget_and_untar https://github.com/facebook/proxygen/archive/refs/tags/${FB_OS_VERSION}.tar.gz proxygen
Expand All @@ -46,6 +56,7 @@ function install_datasketches {
}

function install_presto_deps {
run_and_time install_presto_deps_from_brew
run_and_time install_gperf
run_and_time install_proxygen
run_and_time install_datasketches
Expand Down
Loading