Skip to content

fix(ci): Fix no space error in arrow flight tests#27119

Merged
aditi-pandit merged 1 commit intoprestodb:masterfrom
unidevel:fix-arrow-flight-tests
Feb 10, 2026
Merged

fix(ci): Fix no space error in arrow flight tests#27119
aditi-pandit merged 1 commit intoprestodb:masterfrom
unidevel:fix-arrow-flight-tests

Conversation

@unidevel
Copy link
Copy Markdown
Contributor

@unidevel unidevel commented Feb 10, 2026

Description

https://github.com/prestodb/presto/actions/runs/21840481549/job/63032782954

/usr/lib64/libre2.so.9.0.0  /usr/lib64/libgtest.so.1.11.0 && :
/opt/rh/gcc-toolset-12/root/usr/libexec/gcc/x86_64-redhat-linux/12/ld: final link failed: No space left on device
collect2: error: ld returned 1 exit status
ninja: build stopped: subcommand failed.

Motivation and Context

Impact

Github actions

Test Plan

Test with PR CI

Contributor checklist

  • Please make sure your submission complies with our contributing guide, in particular code style and commit standards.
  • PR description addresses the issue accurately and concisely. If the change is non-trivial, a GitHub Issue is referenced.
  • Documented new properties (with its default value), SQL syntax, functions, or other functionality.
  • If release notes are required, they follow the release notes guidelines.
  • Adequate tests were added if applicable.
  • CI passed.
  • If adding new dependencies, verified they have an OpenSSF Scorecard score of 5.0 or higher (or obtained explicit TSC approval for lower scores).

Release Notes

Please follow release notes guidelines and fill in the release notes below.

== NO RELEASE NOTE ==

Summary by Sourcery

Adjust Arrow Flight CI workflow to free disk space in containerized builds to avoid linker failures.

CI:

  • Mount host /usr and /opt into the Arrow Flight test container to allow disk space cleanup.
  • Add a Free Disk Space step in Arrow Flight CI jobs to remove unnecessary SDKs and tools before building.

@prestodb-ci prestodb-ci added the from:IBM PR from IBM label Feb 10, 2026
@sourcery-ai
Copy link
Copy Markdown
Contributor

sourcery-ai bot commented Feb 10, 2026

Reviewer's Guide

Updates the Arrow Flight GitHub Actions workflow to mount host filesystem paths into the container and run an in-container disk space cleanup step before building, to prevent linker failures due to insufficient disk space.

File-Level Changes

Change Details Files
Mount host /usr and /opt into the Arrow Flight container jobs and run a custom disk space cleanup script before the build steps to avoid no-space linker failures.
  • Configure the GitHub Actions container for both Arrow Flight jobs to mount /usr and /opt from the host into /host_usr and /host_opt inside the container.
  • Add a Free Disk Space step at the start of each job that computes available disk space, removes host DotNet, Android, and CodeQL directories via the mounted paths, and prints available disk space before and after cleanup.
  • Ensure the cleanup runs before checkout and build steps to reduce disk usage prior to compiling and linking native components.
.github/workflows/arrow-flight-tests.yml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@unidevel unidevel force-pushed the fix-arrow-flight-tests branch from 793424d to f559fe1 Compare February 10, 2026 11:07
@unidevel unidevel marked this pull request as ready for review February 10, 2026 13:33
@unidevel unidevel requested review from a team and czentgr as code owners February 10, 2026 13:33
@prestodb-ci prestodb-ci requested review from a team and pratyakshsharma and removed request for a team February 10, 2026 13:33
Copy link
Copy Markdown
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've left some high level feedback:

  • The disk-space cleanup script is duplicated in two jobs; consider extracting it into a reusable workflow step or composite action to keep the logic in one place and avoid divergence over time.
  • Mounting /usr and /opt from the host and running rm -rf on them is quite broad; it might be safer to scope deletions more narrowly (e.g., specific known tool directories) and add guards to verify the expected paths are mounted before removing anything.
  • The getAvailableSpace helper currently ignores its $1 argument and calls df -a on all filesystems; if the intention is to monitor space on the specific mounted host volumes, consider passing an explicit path (e.g., /host_usr or /host_opt) to avoid noisy or misleading output.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- The disk-space cleanup script is duplicated in two jobs; consider extracting it into a reusable workflow step or composite action to keep the logic in one place and avoid divergence over time.
- Mounting `/usr` and `/opt` from the host and running `rm -rf` on them is quite broad; it might be safer to scope deletions more narrowly (e.g., specific known tool directories) and add guards to verify the expected paths are mounted before removing anything.
- The `getAvailableSpace` helper currently ignores its `$1` argument and calls `df -a` on all filesystems; if the intention is to monitor space on the specific mounted host volumes, consider passing an explicit path (e.g., `/host_usr` or `/host_opt`) to avoid noisy or misleading output.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Copy link
Copy Markdown
Member

@hantangwangd hantangwangd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @unidevel

@aditi-pandit aditi-pandit merged commit 63b2600 into prestodb:master Feb 10, 2026
145 of 149 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

from:IBM PR from IBM

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants