fix(ci): Fix no space error in arrow flight tests#27119
Merged
aditi-pandit merged 1 commit intoprestodb:masterfrom Feb 10, 2026
Merged
fix(ci): Fix no space error in arrow flight tests#27119aditi-pandit merged 1 commit intoprestodb:masterfrom
aditi-pandit merged 1 commit intoprestodb:masterfrom
Conversation
Contributor
Reviewer's GuideUpdates the Arrow Flight GitHub Actions workflow to mount host filesystem paths into the container and run an in-container disk space cleanup step before building, to prevent linker failures due to insufficient disk space. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
793424d to
f559fe1
Compare
Contributor
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- The disk-space cleanup script is duplicated in two jobs; consider extracting it into a reusable workflow step or composite action to keep the logic in one place and avoid divergence over time.
- Mounting
/usrand/optfrom the host and runningrm -rfon them is quite broad; it might be safer to scope deletions more narrowly (e.g., specific known tool directories) and add guards to verify the expected paths are mounted before removing anything. - The
getAvailableSpacehelper currently ignores its$1argument and callsdf -aon all filesystems; if the intention is to monitor space on the specific mounted host volumes, consider passing an explicit path (e.g.,/host_usror/host_opt) to avoid noisy or misleading output.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The disk-space cleanup script is duplicated in two jobs; consider extracting it into a reusable workflow step or composite action to keep the logic in one place and avoid divergence over time.
- Mounting `/usr` and `/opt` from the host and running `rm -rf` on them is quite broad; it might be safer to scope deletions more narrowly (e.g., specific known tool directories) and add guards to verify the expected paths are mounted before removing anything.
- The `getAvailableSpace` helper currently ignores its `$1` argument and calls `df -a` on all filesystems; if the intention is to monitor space on the specific mounted host volumes, consider passing an explicit path (e.g., `/host_usr` or `/host_opt`) to avoid noisy or misleading output.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
This was referenced Mar 31, 2026
15 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
https://github.com/prestodb/presto/actions/runs/21840481549/job/63032782954
Motivation and Context
Impact
Github actions
Test Plan
Test with PR CI
Contributor checklist
Release Notes
Please follow release notes guidelines and fill in the release notes below.
Summary by Sourcery
Adjust Arrow Flight CI workflow to free disk space in containerized builds to avoid linker failures.
CI: