docs(native): Add runtime metrics documentation#27109
docs(native): Add runtime metrics documentation#27109steveburnett merged 22 commits intoprestodb:masterfrom
Conversation
Document presto_cpp.worker_runtime_uptime_secs and 60+ other undocumented runtime metrics from Counters.h. Resolves: #27007
|
🧙 Sourcery has finished reviewing your pull request! Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
steveburnett
left a comment
There was a problem hiding this comment.
Thanks for all of this! Just a nit of phrasing.
garimauttam
left a comment
There was a problem hiding this comment.
Resolved comment.
steveburnett
left a comment
There was a problem hiding this comment.
LGTM! (docs)
Pull updated branch, new local doc build, looks good. Thanks!
Document presto_cpp.worker_runtime_uptime_secs and 60+ other undocumented runtime metrics from Counters.h. Resolves: #27007
|
Thanks for the review! |
…arimauttam/presto into docs/add-runtime-metrics-documentation
|
Thanks @garimauttam for this code. There are several conflicts between this code and #26875 that was submit recently. Please can you rebase to help us continue the review more effectively. |
|
Sure will rebase it. |
Document presto_cpp.worker_runtime_uptime_secs and 60+ other undocumented runtime metrics from Counters.h. Resolves: #27007
…arimauttam/presto into docs/add-runtime-metrics-documentation
steveburnett
left a comment
There was a problem hiding this comment.
Noticed a formatting nit throughout. Please address this when you can.
9c432a7 to
1606534
Compare
steveburnett
left a comment
There was a problem hiding this comment.
LGTM! (docs)
Pull updated branch, new local doc build, looks good. Thanks for the update!
Description
Adds comprehensive documentation for
presto_cpp.worker_runtime_uptime_secsand all other undocumented runtime metrics.Related Issue
Resolves #27007
Changes
presto_cpp/metrics.rstdocumenting 60+ runtime metricspresto-cpp.rstto include metrics in table of contentsfeatures.rstto reference the comprehensive metrics docsTesting
./buildChecklist
Summary by Sourcery
Document native runtime metrics for Presto C++ and integrate the new metrics reference into the existing documentation structure.
Documentation:
== NO RELEASE NOTE ==