Skip to content

misc(native): Minor warning fixes #27102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
amitkdutta merged 1 commit into from
Feb 7, 2026
Merged

misc(native): Minor warning fixes #27102

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion presto-native-execution/presto_cpp/main/http/HttpClient.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,7 +149,7 @@ std::unique_ptr<folly::IOBuf> HttpResponse::consumeBody(
for (auto& iobuf : bodyChain_) {
const auto length = iobuf->length();
::memcpy(curr, iobuf->data(), length);
curr = (char*)curr + length;
curr = static_cast<char*>(curr) + length;
iobuf.reset();
}
bodyChain_.clear();
Expand Down
4 changes: 2 additions & 2 deletions presto-native-execution/presto_cpp/main/http/HttpServer.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,13 +63,13 @@ class AbstractRequestHandler : public proxygen::RequestHandler {
body_.emplace_back(std::move(body));
}

void onUpgrade(proxygen::UpgradeProtocol proto) noexcept override {}
void onUpgrade(proxygen::UpgradeProtocol /*proto*/) noexcept override {}

void requestComplete() noexcept override {
delete this;
}

void onError(proxygen::ProxygenError err) noexcept override {
void onError(proxygen::ProxygenError /*err*/) noexcept override {
delete this;
}

Expand Down
2 changes: 1 addition & 1 deletion presto-native-execution/presto_cpp/main/http/filters/InternalAuthenticationFilter.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,7 @@ void InternalAuthenticationFilter::onError(
delete this;
}

void InternalAuthenticationFilter::sendGenericErrorResponse(void) {
void InternalAuthenticationFilter::sendGenericErrorResponse() {
/// Indicate to upstream an error occurred and make sure
/// no further forwarding occurs.
upstream_->onError(proxygen::kErrorUnsupportedExpectation);
Expand Down
4 changes: 2 additions & 2 deletions presto-native-execution/presto_cpp/main/http/filters/InternalAuthenticationFilter.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,9 +47,9 @@ class InternalAuthenticationFilter : public proxygen::Filter {
void onError(proxygen::ProxygenError err) noexcept override;

private:
void sendGenericErrorResponse(void);
void sendGenericErrorResponse();

void sendUnauthorizedResponse(void);
void sendUnauthorizedResponse();

void processAndVerifyJwt(
const std::string& token,
Expand Down
2 changes: 1 addition & 1 deletion presto-native-execution/presto_cpp/main/http/filters/StatsFilter.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ class StatsFilterFactory : public proxygen::RequestHandlerFactory {

proxygen::RequestHandler* onRequest(
proxygen::RequestHandler* handler,
proxygen::HTTPMessage* msg) noexcept override {
proxygen::HTTPMessage* /*msg*/) noexcept override {
return new StatsFilter(handler);
}
};
Expand Down
Loading